Skip to content

Fix unhandled exception when double-clicking in scroll bar area with no selected nodes #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianrob merged 5 commits into from
Jul 10, 2025
Merged

Fix unhandled exception when double-clicking in scroll bar area with no selected nodes #2254

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b908bd
Initial plan
Copilot Jul 7, 2025
eddd167
Fix unhandled exception when no nodes selected in DoViewInCallers and…
Copilot Jul 7, 2025
b7b0395
Fix performance regression by optimizing GetSelectedNodes() usage in …
Copilot Jul 8, 2025
6d2c944
Add blank line between methods to fix formatting
Copilot Jul 10, 2025
b828b53
Update comments.
brianrob Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/PerfView/StackViewer/StackWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2592,7 +2592,13 @@ private void DoHyperlinkHelp(object sender, ExecutedRoutedEventArgs e)
private void ByName_MouseDoubleClick(object sender, MouseButtonEventArgs e)
{
e.Handled = true;
DoViewInCallers(sender, null);

// Check if a single node is selected before proceeding
// This mirrors the CanExecute check for ViewInCallersCommand
if (GetSelectedNodes().Count == 1)
{
DoViewInCallers(sender, null);
}
}
internal void DataGrid_MouseDoubleClick(object sender, MouseButtonEventArgs e)
Copy link
Member

@mconnew mconnew Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: formatting, should be new line between methods.

Copy link
Contributor Author

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed formatting by adding blank line between methods in commit 6d2c944.

{
Expand Down