Skip to content

Fix IndexOutOfRangeException when we iterate over all the Generations and try to access GenData #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianrob merged 5 commits into from
Jan 30, 2025
Merged

Fix IndexOutOfRangeException when we iterate over all the Generations and try to access GenData #2154

brianrob merged 5 commits into from
Jan 30, 2025
+30 −16

Conversation

@mrsharm
Copy link
Contributor

@mrsharm mrsharm commented Jan 29, 2025 •
edited
Loading

This PR fixes cases where we are accessing GenData for cases where certain generations e.g., POH don't exist.

CC: @Maoni0

Tested:

  1. On a trace with no POH allocations.
  2. On a trace with POH allocations.
  3. On a trace from .NET Framework.

Maoni0
Maoni0 reviewed Jan 30, 2025
View reviewed changes
Maoni0
Maoni0 reviewed Jan 30, 2025
View reviewed changes
@mrsharm mrsharm marked this pull request as ready for review January 30, 2025 17:18
@mrsharm mrsharm requested a review from brianrob as a code owner January 30, 2025 17:18
@brianrob
Copy link
Member

brianrob commented Jan 30, 2025

@Maoni0 PTAL. Thanks.

Maoni0
Maoni0 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianrob brianrob merged commit 8850b34 into microsoft:main Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianrob brianrob brianrob approved these changes

+1 more reviewer

@Maoni0 Maoni0 Maoni0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrsharm @brianrob @Maoni0