Skip to content

Conversation

@zhangxiang1993
Copy link
Contributor

Description: Because the default CPUExecutionProvider is registered inside session initialization and SessionCreation Logger is inside model loading. So CPUExecutionProvider would be missed to be logged.

This change is to move Logging Session Creation after the session is initialized.

@zhangxiang1993 zhangxiang1993 requested a review from a team as a code owner November 26, 2019 01:50
@skottmckay
Copy link
Contributor

Description: Because the default CPUExecutionProvider is registered inside session initialization and SessionCreation Logger is inside model loading. So CPUExecutionProvider would be missed to be logged.

This change is to move Logging Session Creation after the session is initialized.

Can you clarify how moving the creation to later in the setup process (Initialize is called after Load) helps with something about the CPUExecutionProvider not being logged?

@zhangxiang1993
Copy link
Contributor Author

Description: Because the default CPUExecutionProvider is registered inside session initialization and SessionCreation Logger is inside model loading. So CPUExecutionProvider would be missed to be logged.
This change is to move Logging Session Creation after the session is initialized.

Can you clarify how moving the creation to later in the setup process (Initialize is called after Load) helps with something about the CPUExecutionProvider not being logged?

  1. We are logging the EPs registered in execution_providers_
  2. Non-default execution providers will be registered before loader according to options, so logger inside loader is able to log EPs.
  3. Default execution provider, CPUExectionProvider will be registered when session is initialized, which happens after the logging. So the EP info is lost for the logger inside the loader.

This change is to move the logger to the end of initialization so CPUEP is registered before logging.

@pranavsharma pranavsharma merged commit d6c8492 into master Nov 27, 2019
@zhangxiang1993 zhangxiang1993 deleted the user/xianz/Log_CPU_EP branch January 18, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants