Changed ConvBase into a class member variable #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all Conv-family classes inherit from both ConvBase and OpKernel. Since what ConvBase provides is all about processing convolution attributes, it's more natural to move it as a class member variable. This change renamed ConvBase to ConvAttributes and moved it into a separate file conv_attributes by its own. Instead of inheriting from ConvBase, now each Conv-related class has a class member variable that is of type ConvAttributes. Hence, we removed unecessary multiple inheritance and increase composibility. More importantly, the change made it possible for some other providers such as Nuphar be able to re-use the functionalities provided by ConvAttributes class. Note that we also made similar changes to ConvTransposeBase.
ke1337
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all Conv-family classes inherit from both ConvBase
and OpKernel. Since what ConvBase provides is all about
processing convolution attributes, it's more natural to move it as
a class member variable.
This change renamed ConvBase to ConvAttributes and moved
it into a separate file conv_attributes by its own. Instead of
inheriting from ConvBase, now each Conv-related class has a
class member variable that is of type ConvAttributes.
Hence, we removed necessary multiple inheritance and increase
composibility. More importantly, the change made it possible for
some other providers such as Nuphar be able to re-use the functionalities
provided by ConvAttributes class.
Note that we also made similar changes to ConvTransposeBase.