Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@Tixxx
Copy link
Contributor

@Tixxx Tixxx commented Apr 27, 2021

This PR adds the following support:
depth to space kernel to run office super resolution model
6d tensor support in coordinate library to run model zoo super resolution
a super resolution benchmarking tool that compares the performance of onnxjs to the latest tfjs with profiling info.

This pr also exposes a logger config(only contains a log level field) to the inference session so that logger's log level can be configured from onnxjs api.

***All the required changes are verified currently. This PR is for viewing diffs only. Changes are being migrated to the new ORT repo.

@Tixxx Tixxx requested review from duli2012, fs-eire and xzhu1900 April 27, 2021 07:43
@@ -0,0 +1,5 @@
# Licenses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be license or readme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we put tfjs in our benchmark, we need to specify tfjs's license here to state that we are using some other project. I think i included a README in the same folder.

@@ -0,0 +1,38 @@
# Benchmarks
Copy link
Contributor

@duli2012 duli2012 Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we generalize this sub project to other models besides SR, which would be very useful feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i put a TODO in the main index.js file to improve this benchmark to take arbitrary models and configs. For that, we would need a benchmark driver similar to our test-runner-cli. I will do a followup change just for the benchmarking tool.

@Tixxx Tixxx force-pushed the tix/depth_to_space branch from 934b17e to 4c5d979 Compare May 11, 2021 17:26
@Tixxx Tixxx changed the title Support super resolution models and benchmarking (WIP) Support super resolution models and benchmarking May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants