Skip to content

fix: publish pipeline broken APIScan task #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzhao271 merged 4 commits into from
Jan 25, 2025
Merged

fix: publish pipeline broken APIScan task #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3db6bd3
chore: add apiScanUseZ7 flag
rzhao271 Jan 24, 2025
e01e108
Log spawn result
rzhao271 Jan 24, 2025
29206b0
Fix increment-version.js to work on Windows
rzhao271 Jan 25, 2025
fdda363
Fix APIScan parameters
rzhao271 Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,7 @@ extends:
tag: latest
${{ else }}:
tag: beta

apiScanExcludes: 'package/third_party/conpty/1.20.240626001/win10-arm64/*.*'
apiScanSoftwareName: 'vscode-node-pty'
apiScanSoftwareVersion: '1'
5 changes: 4 additions & 1 deletion scripts/increment-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ function getNextBetaVersion() {
}

function getPublishedVersions(version, tag) {
const versionsProcess = cp.spawnSync('npm', ['view', packageJson.name, 'versions', '--json']);
const isWin32 = process.platform === 'win32';
const versionsProcess = isWin32 ?
cp.spawnSync('npm.cmd', ['view', packageJson.name, 'versions', '--json'], { shell: true }) :
cp.spawnSync('npm', ['view', packageJson.name, 'versions', '--json']);
const versionsJson = JSON.parse(versionsProcess.stdout);
if (tag) {
return versionsJson.filter(v => !v.search(new RegExp(`${version}-${tag}[0-9]+`)));
Expand Down