-
Notifications
You must be signed in to change notification settings - Fork 452
Introducing Performance Logger and callback handling mechanism #2706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
============================================
- Coverage 56.35% 56.33% -0.03%
+ Complexity 4531 4525 -6
============================================
Files 149 151 +2
Lines 34376 34478 +102
Branches 5734 5745 +11
============================================
+ Hits 19373 19423 +50
- Misses 12393 12421 +28
- Partials 2610 2634 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
David-Engel
reviewed
Jul 16, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Aug 28, 2025
src/main/java/com/microsoft/sqlserver/jdbc/PerformanceLogCallback.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/PerformanceLogCallback.java
Outdated
Show resolved
Hide resolved
Ananya2
reviewed
Aug 29, 2025
David-Engel
reviewed
Oct 28, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
divang
approved these changes
Nov 6, 2025
Ananya2
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a foundational change for introducing performance loggers to the
mssql-jdbcdriver. The new logging infrastructure is designed to enable tracking the performance of various critical activities within the driver, such as:New Logger
java.util.logginglogger namedcom.microsoft.sqlserver.jdbc.PerformanceMetrics.Connectionhas been introduced.com.microsoft.sqlserver.jdbc.PerformanceMetrics.Statement) will be introduced to cover other areas such as statement execution, result set handling, etc.Performance Activities
PerformanceActivityenum.Callback Handling
Working of Performance Logger
When a performance-sensitive activity such as connection or login begins, a logger instance is created and records the start time. The activity is then executed within the logger’s scope. Once the activity completes or fails, the logger’s close() method is called to capture the end time and calculate the duration. If a callback is registered, the logger publishes the activity type, connection ID, duration, and any exception to it. The same information is also logged using the Java logger, making the metrics available for monitoring and diagnostics.
Testing
-All existing tests ensure testing of newly added code.
This change lays the groundwork for a robust, extensible performance monitoring framework in the
mssql-jdbcdriver, enabling users to better observe, analyze, and optimize their application's interactions with SQL Server.