Add test for null values when getting DTV values #2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ananya2
requested review from
David-Engel,
Jeffery-Wasty,
divang,
lilgreenbird,
machavan and
tkyc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2617 +/- ##
============================================
+ Coverage 51.54% 51.57% +0.03%
- Complexity 3996 4000 +4
============================================
Files 147 147
Lines 33694 33694
Branches 5630 5630
============================================
+ Hits 17366 17378 +12
- Misses 13877 13883 +6
+ Partials 2451 2433 -18 ☔ View full report in Codecov by Sentry. |
machavan
approved these changes
Feb 27, 2025
divang
previously approved these changes
Feb 27, 2025
machavan
previously approved these changes
Feb 27, 2025
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
changed the title
…g test, removed redundant cleanup logging, and handled table cleanup in @AfterEach.
machavan
approved these changes
Mar 3, 2025
Jeffery-Wasty
approved these changes
Mar 3, 2025
David-Engel
approved these changes
Mar 3, 2025
tkyc
approved these changes
Mar 3, 2025
David-Engel
approved these changes
Mar 3, 2025
github-project-automation
bot
moved this from In progress
to Closed/Merged PRs
in MSSQL JDBC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for datatypes-unit fx test case failure while keeping perf fix. Ensure exception is thrown before returning null in getValue()
Adds test case for #2600