Skip to content

Conversation

@tkyc
Copy link
Contributor

@tkyc tkyc commented Nov 12, 2024

Internal pipelines are failing because the error message returned from failed AAD password auth has changed. Updated tests.

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.96%. Comparing base (b27b0c1) to head (05d210d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2538      +/-   ##
============================================
- Coverage     51.01%   50.96%   -0.06%     
+ Complexity     3912     3898      -14     
============================================
  Files           147      147              
  Lines         33371    33371              
  Branches       5593     5593              
============================================
- Hits          17024    17007      -17     
+ Misses        13962    13957       -5     
- Partials       2385     2407      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkyc tkyc merged commit ef6b770 into main Nov 13, 2024
18 of 19 checks passed
@tkyc tkyc deleted the fedauth-err-test-update branch November 13, 2024 17:34
divang pushed a commit that referenced this pull request Nov 18, 2024
Jeffery-Wasty pushed a commit that referenced this pull request Feb 4, 2025
Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/fedauth/ErrorMessageTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/fedauth/FedauthCommon.java
Jeffery-Wasty added a commit that referenced this pull request Feb 4, 2025
Jeffery-Wasty added a commit that referenced this pull request Mar 19, 2025
…date (#2602)

* Update build.gradle

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml

* ManagedIdentity I

Signed-off-by: Jeff Wasty <[email protected]>

* Updates for running tests with managed identity (#2416)

Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java
#	src/test/java/com/microsoft/sqlserver/jdbc/TestUtils.java
#	src/test/java/com/microsoft/sqlserver/jdbc/connection/TimeoutTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetaDataTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java

* Delete mistakenly added files

* Delete mistakenly added files

* Revert "Delete mistakenly added files"

This reverts commit 19abc22.

* Revert "Delete mistakenly added files"

This reverts commit 04f8c82.

* Revert "Updates for running tests with managed identity (#2416)"

This reverts commit b727a96.

* Revert "ManagedIdentity I"

This reverts commit 6d5c519.

* Delete garbage

* Fixed Managed Identity tests (#1935)

Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/MSITest.java

* Managed Identity dev experience improvements #1936

Signed-off-by: Jeff Wasty <[email protected]>

* Updates for running tests with managed identity #2416

Signed-off-by: Jeff Wasty <[email protected]>

* cleanup

Signed-off-by: Jeff Wasty <[email protected]>

* Update tests for Kerberos

Signed-off-by: Jeff Wasty <[email protected]>

* Remove unused test

* tsc=true for ae

Signed-off-by: Jeff Wasty <[email protected]>

* Add tags for testDefaultRetry

* Remove unstable test

Signed-off-by: Jeff Wasty <[email protected]>

* Add throttling error message to tests (#2044)

Signed-off-by: Jeff Wasty <[email protected]>

* Updated fedauth tests to run on diff test server (#2062)

Signed-off-by: Jeff Wasty <[email protected]>

* Update fedauth tests to use cached tokens and retry if throttled (#2077)

Signed-off-by: Jeff Wasty <[email protected]>

* Add back missing import

Signed-off-by: Jeff Wasty <[email protected]>

* Resolve static issue with IOBuffer

Signed-off-by: Jeff Wasty <[email protected]>

* Add back a missing import

* Fixed TestUtils

* Remove mistakenly added code

* Cleanup

* Cleanup testutils

* More cleanup

* Add more time for 'testDefaultRetry' &
Fix tests for testing encrypt options (#2215)

* Update setAEConnectionString

* Updated fedauth error tests (#2538)

Signed-off-by: Jeff Wasty <[email protected]>

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/fedauth/ErrorMessageTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/fedauth/FedauthCommon.java

* Update fedAuth tests

* Revert "Updated fedauth error tests (#2538)"

This reverts commit dfb4b77.

* Revert "Update fedAuth tests"

This reverts commit da5c58b.

* Added ActiveDirectoryServicePrincipalCertificate for tests

* Add 'requireSecret' exclude tag for tests which require adding a secret to app registration

* Version update

* Add connection retry changes from 2513 to ensure existing timing tests pass

* Adjust timings on tests as the fix requires code changes we should not incorporate for this release

* Changelog

* Update dependency versions

---------

Signed-off-by: Jeff Wasty <[email protected]>
Co-authored-by: lilgreenbird <[email protected]>
Co-authored-by: Terry Chow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

5 participants