Fix SAL annotation placement on function templates#5895
Merged
Conversation
mtfriesen
approved these changes
Mar 26, 2026
guhetier
added a commit
that referenced
this pull request
Mar 27, 2026
SAL annotations (`_Success_`, `_Function_class_`) placed before the `template` keyword cause MSVC compilation errors (C2059) when TVS / static analysis is enabled. The `template` head must always come first; annotations go between it and the return type. Fixed 5 occurrences: - `src/perf/lib/SecNetPerfMain.cpp`: 4 instances of `_Success_` before `template` - `src/test/lib/ApiTest.cpp`: 1 instance of `_Function_class_` before `template` Existing tests cover this change. No new tests needed — this is a compilation fix only (no behavioral change). No documentation impact.
guhetier
added a commit
that referenced
this pull request
Mar 27, 2026
## Description SAL annotations (`_Success_`, `_Function_class_`) placed before the `template` keyword cause MSVC compilation errors (C2059) when TVS / static analysis is enabled. The `template` head must always come first; annotations go between it and the return type. Fixed 5 occurrences: - `src/perf/lib/SecNetPerfMain.cpp`: 4 instances of `_Success_` before `template` - `src/test/lib/ApiTest.cpp`: 1 instance of `_Function_class_` before `template` ## Testing Existing tests cover this change. No new tests needed — this is a compilation fix only (no behavioral change). ## Documentation No documentation impact.
This was referenced Mar 27, 2026
guhetier
added a commit
that referenced
this pull request
Mar 30, 2026
Cherry-pick of #5895 ## Description SAL annotations (`_Success_`, `_Function_class_`) placed before the `template` keyword cause MSVC compilation errors (C2059) when TVS / static analysis is enabled. The `template` head must always come first; annotations go between it and the return type. Fixed 5 occurrences: - `src/perf/lib/SecNetPerfMain.cpp`: 4 instances of `_Success_` before `template` - `src/test/lib/ApiTest.cpp`: 1 instance of `_Function_class_` before `template` ## Testing Existing tests cover this change. No new tests needed — this is a compilation fix only (no behavioral change). ## Documentation No documentation impact.
guhetier
added a commit
that referenced
this pull request
Mar 30, 2026
SAL annotations (`_Success_`, `_Function_class_`) placed before the `template` keyword cause MSVC compilation errors (C2059) when TVS / static analysis is enabled. The `template` head must always come first; annotations go between it and the return type. Fixed 5 occurrences: - `src/perf/lib/SecNetPerfMain.cpp`: 4 instances of `_Success_` before `template` - `src/test/lib/ApiTest.cpp`: 1 instance of `_Function_class_` before `template` Existing tests cover this change. No new tests needed — this is a compilation fix only (no behavioral change). No documentation impact.
guhetier
added a commit
that referenced
this pull request
Mar 30, 2026
Cherry-pick of #5895 ## Description SAL annotations (`_Success_`, `_Function_class_`) placed before the `template` keyword cause MSVC compilation errors (C2059) when TVS / static analysis is enabled. The `template` head must always come first; annotations go between it and the return type. Fixed 5 occurrences: - `src/perf/lib/SecNetPerfMain.cpp`: 4 instances of `_Success_` before `template` - `src/test/lib/ApiTest.cpp`: 1 instance of `_Function_class_` before `template` ## Testing Existing tests cover this change. No new tests needed — this is a compilation fix only (no behavioral change). ## Documentation No documentation impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SAL annotations (
_Success_,_Function_class_) placed before thetemplatekeyword cause MSVC compilation errors (C2059) when TVS / static analysis is enabled. Thetemplatehead must always come first; annotations go between it and the return type.Fixed 5 occurrences:
src/perf/lib/SecNetPerfMain.cpp: 4 instances of_Success_beforetemplatesrc/test/lib/ApiTest.cpp: 1 instance of_Function_class_beforetemplateTesting
Existing tests cover this change. No new tests needed — this is a compilation fix only (no behavioral change).
Documentation
No documentation impact.