Improve support for custom OpenSSL selection#5848
Open
masa-koz wants to merge 1 commit intomicrosoft:mainfrom
Open
Improve support for custom OpenSSL selection#5848masa-koz wants to merge 1 commit intomicrosoft:mainfrom
masa-koz wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves support for using external OpenSSL installations with the build system, especially for static and shared library builds. It introduces a new Cargo feature, better environment variable handling, and more robust CMake logic for finding and linking OpenSSL. The changes are grouped by theme below.
Build system improvements for external OpenSSL:
openssl-externalCargo feature to enable building with an external OpenSSL installation. (Cargo.tomlCargo.tomlR93)scripts/build.rs) to handle the new feature, passing appropriate CMake definitions and reading OpenSSL paths from environment variables (OPENSSL_DIR,OPENSSL_INCLUDE_DIR,OPENSSL_LIB_DIR). (scripts/build.rsscripts/build.rsR51-R64)artifactssubdirectory for better organization. (scripts/build.rsscripts/build.rsL32-R32)CMake configuration enhancements:
QUIC_OPENSSL_DIRCMake cache variable to specify the path to an OpenSSL installation, complementing the existing include and lib directory options. (CMakeLists.txtCMakeLists.txtR115)CMakeLists.txtCMakeLists.txtR776-R807)Testing
No
Documentation
TBD