Add test case to exploit crashing bug in QuicSendFlush#5825
Draft
Add test case to exploit crashing bug in QuicSendFlush#5825
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5825 +/- ##
==========================================
- Coverage 86.11% 84.80% -1.31%
==========================================
Files 60 60
Lines 18729 18729
==========================================
- Hits 16129 15884 -245
- Misses 2600 2845 +245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request a new unit test for the send logic. The main change is addition of a unit test for the send path, specifically targeting pacing logic, that potentially exposes a crashing bug in Quic Send logic.
Testing
Testing Enhancements:
SendTest.cppto the unit test build (src/core/unittest/CMakeLists.txt) and implemented a new test file for the send logic:FlushPacingDelayed) that validates the pacing behavior in the send path, including setup for connection state, congestion control, and timer logic. [1] [2]To run the test
The test will fail.
Documentation
N/A