Skip to content

Switch epoll and kqueue to level triggers #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thhous-msft merged 5 commits into from
May 7, 2022
Merged

Switch epoll and kqueue to level triggers #2655

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e099874
Switch epoll and kqueue to level triggers
thhous-msft Apr 22, 2022
441fd81
Fix triggers
thhous-msft Apr 23, 2022
cca5f1b
Remove while true loop
thhous-msft Apr 27, 2022
e376e8a
Try just 1 receive
thhous-msft Apr 28, 2022
608803b
Revert to 4
thhous-msft Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/platform/datapath_epoll.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,7 +1431,7 @@ CxPlatSocketContextStartReceive(
}

struct epoll_event SockFdEpEvt = {
.events = EPOLLIN | EPOLLET,
.events = EPOLLIN,
.data = {
.ptr = &SocketContext->EventContexts[QUIC_SOCK_EVENT_SOCKET]
}
Expand Down Expand Up @@ -1644,7 +1644,7 @@ CxPlatSocketContextSendComplete(
CXPLAT_SEND_DATA* SendData = NULL;

struct epoll_event SockFdEpEvt = {
.events = EPOLLIN | EPOLLET,
.events = EPOLLIN,
.data = {
.ptr = &SocketContext->EventContexts[QUIC_SOCK_EVENT_SOCKET]
}
Expand Down Expand Up @@ -2611,7 +2611,7 @@ CxPlatSocketSendInternal(
}
SendPending = TRUE;
struct epoll_event SockFdEpEvt = {
.events = EPOLLIN | EPOLLOUT | EPOLLET,
.events = EPOLLIN | EPOLLOUT,
.data = {
.ptr = &SocketContext->EventContexts[QUIC_SOCK_EVENT_SOCKET]
}
Expand Down
2 changes: 1 addition & 1 deletion src/platform/datapath_kqueue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@ CxPlatSocketContextStartReceive(
struct kevent Event = {0};
EV_SET(
&Event, SocketContext->SocketFd,
EVFILT_READ, EV_ADD | EV_ENABLE | EV_CLEAR,
EVFILT_READ, EV_ADD | EV_ENABLE,
0,
0,
(void*)SocketContext);
Expand Down