Add missing HC resources

[beervoley]

Description

These PR adds missing HighContrast Resources to Common themeresources.

Motivation and Context

When switching to HighContrast theme the app would crash because the resources that Controls reference are not defined for the HighContrast theme. With this PR it will be fixed.

How Has This Been Tested?

Manually switched to HC and made sure defined resources are working.

[beervoley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[beervoley]

<StaticResource x:Key="DefaultTextForegroundThemeBrush" ResourceKey="TextFillColorPrimaryBrush" />
<StaticResource x:Key="DefaultApplicationBackgroundThemeBrush" ResourceKey="SolidBackgroundFillColorTertiaryBrush" />
Do we still need these brushes?
As well as these:
<SolidColorBrush x:Key="SystemColorWindowTextColorBrush" Color="{ThemeResource SystemColorWindowTextColor}" />
<SolidColorBrush x:Key="SystemColorWindowColorBrush" Color="{ThemeResource SystemColorWindowColor}" />
These two were being used only in High Contrast theme and are not being used anymore anywhere in the code. Unless someone depends on it already?

[ranjeshj]

<StaticResource x:Key="DefaultTextForegroundThemeBrush" ResourceKey="TextFillColorPrimaryBrush" />
<StaticResource x:Key="DefaultApplicationBackgroundThemeBrush" ResourceKey="SolidBackgroundFillColorTertiaryBrush" />
Do we still need these brushes?
As well as these:
<SolidColorBrush x:Key="SystemColorWindowTextColorBrush" Color="{ThemeResource SystemColorWindowTextColor}" />
<SolidColorBrush x:Key="SystemColorWindowColorBrush" Color="{ThemeResource SystemColorWindowColor}" />
These two were being used only in High Contrast theme and are not being used anymore anywhere in the code. Unless someone depends on it already?

If someone is using it, we do not want to cause a crash. @YuliKl as FYI

[karkarl]

<StaticResource x:Key="DefaultTextForegroundThemeBrush" ResourceKey="TextFillColorPrimaryBrush" />
<StaticResource x:Key="DefaultApplicationBackgroundThemeBrush" ResourceKey="SolidBackgroundFillColorTertiaryBrush" />
Do we still need these brushes?
As well as these:
<SolidColorBrush x:Key="SystemColorWindowTextColorBrush" Color="{ThemeResource SystemColorWindowTextColor}" />
<SolidColorBrush x:Key="SystemColorWindowColorBrush" Color="{ThemeResource SystemColorWindowColor}" />
These two were being used only in High Contrast theme and are not being used anymore anywhere in the code. Unless someone depends on it already?

I initially added DefaultApplicationBackgroundThemeBrush to fix HC crashes in some test pages. It is now a duplicate of the background brush you added, so can be removed once you replace the current instances.

[ranjeshj]

<StaticResource x:Key="DefaultTextForegroundThemeBrush" ResourceKey="TextFillColorPrimaryBrush" />
<StaticResource x:Key="DefaultApplicationBackgroundThemeBrush" ResourceKey="SolidBackgroundFillColorTertiaryBrush" />
Do we still need these brushes?
As well as these:
<SolidColorBrush x:Key="SystemColorWindowTextColorBrush" Color="{ThemeResource SystemColorWindowTextColor}" />
<SolidColorBrush x:Key="SystemColorWindowColorBrush" Color="{ThemeResource SystemColorWindowColor}" />
These two were being used only in High Contrast theme and are not being used anymore anywhere in the code. Unless someone depends on it already?

I initially added DefaultApplicationBackgroundThemeBrush to fix HC crashes in some test pages. It is now a duplicate of the background brush you added, so can be removed once you replace the current instances.

Lets do a separate change to remove this key..

[YuliKl]

@beervoley I'm getting some feedback from design about these values, so we may need to change a few brush mapping before you complete the PR.

[YuliKl]

Oops, didn't notice this was already merged.

[marksfoster]

Instead of creating all these solid color brushes (save on perf) why don't we add the rest of these brushes (SystemColorWindowTextColorBrush and SystemColorWindowColorBrush are already in this location and ready to go):

<SolidColorBrush x:Key="SystemColorWindowColorBrush" Color="{ThemeResource SystemColorWindowColor}" /> <SolidColorBrush x:Key="SystemColorWindowTextColorBrush" Color="{ThemeResource SystemColorWindowTextColor}" /> <SolidColorBrush x:Key="SystemColorHighlightColorBrush" Color="{ThemeResource SystemColorHighlightColor}" /> <SolidColorBrush x:Key="SystemColorHighlightTextColorBrush" Color="{ThemeResource SystemColorHighlightTextColor}" /> <SolidColorBrush x:Key="SystemColorButtonFaceColorBrush" Color="{ThemeResource SystemColorButtonFaceColor}" /> <SolidColorBrush x:Key="SystemColorButtonTextColorBrush" Color="{ThemeResource SystemColorButtonTextColor}" /> <SolidColorBrush x:Key="SystemColorHotlightColorBrush" Color="{ThemeResource SystemColorHotlightColor}" /> <SolidColorBrush x:Key="SystemColorGrayTextColorBrush" Color="{ThemeResource SystemColorGrayTextColor}" />

and convert all the brushes you are adding to static resources ( <StaticResource x:Key="TextFillColorPrimaryBrush" ResourceKey="SystemColorButtonTextColorBrush" />) ?