CommandBar closes itself when buttons with flyouts are clicked.#3054
Merged
StephenLPeters merged 1 commit intomasterfrom Aug 6, 2020
Merged
CommandBar closes itself when buttons with flyouts are clicked.#3054StephenLPeters merged 1 commit intomasterfrom
StephenLPeters merged 1 commit intomasterfrom
Conversation
msft-github-bot
added
the
needs-triage
StephenLPeters
added
area-Commanding
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marcelwgn
reviewed
Aug 6, 2020
| Button showCommandBarFlyoutButton = FindElement.ByName<Button>("Show CommandBarFlyout with sub-menu"); | ||
| ToggleButton isFlyoutOpenCheckBox = FindElement.ById<ToggleButton>("IsFlyoutOpenCheckBox"); | ||
|
|
||
| Action openCommandBarAction = () => |
Collaborator
There was a problem hiding this comment.
Is there a specific reason we are defining an action for this?
Member
There was a problem hiding this comment.
This was probably copied from other test methods where we run the action multiple times.
Contributor
Author
There was a problem hiding this comment.
The other tests in the file do it in order to reuse the action. For this tests its only used once and isn't really needed. But I think leaving it as is is probably fine.
llongley
approved these changes
Aug 6, 2020
marcelwgn
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2040 CommandBar closes itself when buttons with flyouts are clicked.
Description
We have logic that excludes buttons with flyouts from the commands which close the command bar. However it wasn't being applied in all cases, this change fixes that.
How Has This Been Tested?
A new interaction test.