Skip to content

Conversation

@sammydeprez
Copy link

This pull request addresses Issue #1167, where HTTP/HTTPS requests could hang indefinitely if the server fails to close the stream. To prevent this, a timeout parameter has been added to the requests.get() call within the convert_uri method.

🔧 Change Summary
Before:

response = self._requests_session.get(uri, stream=True)

After:

response = self._requests_session.get(uri, stream=True, timeout=kwargs.get("timeout", None))

This change allows users to optionally specify a timeout via kwargs, ensuring better control over request behavior and avoiding indefinite hangs.

✅ Benefits

  • Prevents hanging on unresponsive servers
  • Enables customizable timeout handling
  • Backward-compatible: defaults to None if not provided

@jerpint
Copy link

jerpint commented Oct 16, 2025

any updates on merging this?

@sammydeprez
Copy link
Author

There are so many needed PRs open, no one that is merging them 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants