-
Notifications
You must be signed in to change notification settings - Fork 34
Live Share SDK 2.0.0 #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Live Share SDK 2.0.0 #794
Changes from all commits
7059ce7
a663f32
5879aa6
ecbeaf8
0611b48
fd17ce9
887393c
e424043
0066390
f6651da
df65822
1956dff
40957e9
d605f1e
e2b33a7
bbde862
640def5
a875776
e5821ee
f0edcbf
0050369
37f09ca
6957598
811ee43
217519d
cacda7f
0655416
4681998
d40306f
2db81b7
a3e0b20
cbb4ab7
dddcf28
01a704e
e80c59b
ebf6a44
c2e4bd5
6b0babb
ac366c8
34b8084
f2a6105
4eb0ab9
c3e537f
6a57441
8e96a09
89bfabe
bcc9659
e6cb0f5
3b03a0b
9de0002
fdc04c7
54bf1c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| @arun2k17 @corinagum @halbondmsft @pradeepananth @ryanbliss @siduppal @Stevenic | ||
| @pradeepananth @ryanbliss @siduppal @huntj88 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "npm" | ||
| # Only specify the root so dependabot will update all manifests once per package | ||
| # See https://github.com/dependabot/dependabot-core/issues/5226#issuecomment-1179434437 | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| day: "monday" | ||
| # Ignore the following packages because | ||
| # 1. Semver for these packages is not always followed | ||
| # 1. These packages MUST be updated all at the same time (same PR) | ||
| ignore: | ||
| - "fluid-framework", | ||
| - "@fluidframework/test-client-utils" | ||
| - "@fluidframework/test-utils" | ||
| - "@fluidframework/test-runtime-utils" | ||
| - "@fluidframework/azure-client", | ||
| - "@microsoft/teams-js" | ||
| # Updates both the package-lock and package.json, not just package-lock | ||
| versioning-strategy: increase | ||
| - package-ecosystem: "npm" | ||
| # Only specify the root so dependabot will update all manifests once per package | ||
| # See https://github.com/dependabot/dependabot-core/issues/5226#issuecomment-1179434437 | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| day: "monday" | ||
| # Ignore the following packages because | ||
| # 1. Semver for these packages is not always followed | ||
| # 1. These packages MUST be updated all at the same time (same PR) | ||
| ignore: | ||
| - dependency-name: "fluid-framework" | ||
| - dependency-name: "@fluidframework/test-client-utils" | ||
| - dependency-name: "@fluidframework/test-utils" | ||
| - dependency-name: "@fluidframework/test-runtime-utils" | ||
| - dependency-name: "@fluidframework/azure-client" | ||
| - dependency-name: "@microsoft/teams-js" | ||
| # Updates both the package-lock and package.json, not just package-lock | ||
| versioning-strategy: increase |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #!/bin/bash | ||
| cd ../.. | ||
| npm run doctor | ||
| diff=`git diff` | ||
| if [ -z "$diff" ] | ||
| then | ||
| echo "everything formatted" | ||
| exit 0 | ||
| else | ||
| echo "" # empty line | ||
| echo "" # empty line | ||
| echo "FORMATTING NEEDED" | ||
| echo "Please run 'npm run doctor'" | ||
| exit 1 | ||
| fi |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,39 @@ | ||
| name: Build Live Share SDK samples | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
| push: | ||
| branches: [main, mainv2] | ||
| pull_request: | ||
| branches: [main, mainv2] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm install jest | ||
| working-directory: samples/javascript/02.react-video | ||
|
|
||
| - name: "build packages and samples" | ||
| run: npm run build | ||
|
|
||
| # TODO: get scenario_test.sh working | ||
|
|
||
| # - name: "test 02.react-video sample" | ||
| # shell: "bash" | ||
| # run: sh ../../../.github/workflows/scenario_test.sh | ||
| # working-directory: samples/javascript/02.react-video | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 22.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: "npm" | ||
| - run: npm --loglevel verbose ci --ignore-scripts | ||
| timeout-minutes: 20 | ||
|
|
||
| - run: npm install jest | ||
| working-directory: samples/javascript/02.react-video | ||
|
|
||
| - name: "build packages and samples" | ||
| run: npm run build | ||
|
|
||
| # TODO: get scenario_test.sh working | ||
|
|
||
| # - name: "test 02.react-video sample" | ||
| # shell: "bash" | ||
| # run: sh ../../../.github/workflows/scenario_test.sh | ||
| # working-directory: samples/javascript/02.react-video | ||
| Original file line number | Diff line number | Diff line change | |||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | |||||||||||||||||||||||
| name: Check formatting | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| on: | |||||||||||||||||||||||
| push: | |||||||||||||||||||||||
| branches: [main, mainv2] | |||||||||||||||||||||||
| pull_request: | |||||||||||||||||||||||
| branches: [main, mainv2] | |||||||||||||||||||||||
| workflow_dispatch: | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| jobs: | |||||||||||||||||||||||
| build: | |||||||||||||||||||||||
| runs-on: ubuntu-latest | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| strategy: | |||||||||||||||||||||||
| matrix: | |||||||||||||||||||||||
| node-version: [18.x, 22.x] | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| steps: | |||||||||||||||||||||||
| - uses: actions/checkout@v4 | |||||||||||||||||||||||
| - name: Use Node.js ${{ matrix.node-version }} | |||||||||||||||||||||||
| uses: actions/setup-node@v4 | |||||||||||||||||||||||
| with: | |||||||||||||||||||||||
| node-version: ${{ matrix.node-version }} | |||||||||||||||||||||||
| cache: "npm" | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| - run: npm --loglevel verbose ci --ignore-scripts | |||||||||||||||||||||||
| timeout-minutes: 20 | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| - name: "check formatting" | |||||||||||||||||||||||
| run: "bash checkFormatting.sh" | |||||||||||||||||||||||
| working-directory: .github/workflows | |||||||||||||||||||||||
|
Comment on lines
+12
to
+31
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Copilot AutofixAI about 1 month ago To fix the problem, add a
Suggested changeset
1
.github/workflows/live-share-formatting.yaml
Copilot is powered by AI and may make mistakes. Always verify output.
Positive FeedbackNegative Feedback
Refresh and try again.
|
|||||||||||||||||||||||
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI about 1 month ago
To fix the issue, add a
permissionsblock with least-privilege required by the workflow. As all current steps only read repository contents and never write to them (e.g., no pushes, PR creation, artifact upload), the minimal needed permission is for reading repository contents (contents: read).The CodeQL warning suggests placing the
permissionsblock either at the workflow root or inside the job. Adding it at the root ensures it applies to all jobs (present and future) unless overridden.Edit the file
.github/workflows/live-share-build-samples.yaml, and add the following block near the top, after thename:field and before/untiljobs:. Ensure proper indentation and spacing. No new imports or methods are needed.