Skip to content

Conversation

@huntj88
Copy link
Contributor

@huntj88 huntj88 commented Feb 26, 2024

Live share changes required to work with Fluid v2.

remaining work:

  • Unit tests do not work yet (once they are fixed update unit test pipeline to include mainv2 branch)
  • dispose cannot be overridden or has been deleted from DataObject class

@huntj88 huntj88 marked this pull request as ready for review February 26, 2024 22:03
Copy link
Contributor

@ryanbliss ryanbliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huntj88 huntj88 merged commit 7059ce7 into mainv2 Feb 26, 2024
@huntj88 huntj88 deleted the jameshunt/fluidv2 branch February 26, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants