Async to Sync Revert for Java Generation#3672
Merged
Conversation
andrueastman
reviewed
Nov 7, 2023
Contributor
andrueastman
left a comment
andrueastman
left a comment
There was a problem hiding this comment.
I believe we also need to
- Update unit tests
- Rename the
sendXXXmethods in the generated code to remove theasyncsuffix.
baywet
requested changes
Nov 7, 2023
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
- changelog
- call to request adapter (remove async suffix)
- a couple of places we're using thenAccept and others as far as I can remember
- (maybe) exception management, depending on the resolution on kiota java
ramsessanchez
changed the title
Contributor
Author
|
Integration tests will fail until Kiota-Java is complete. |
baywet
previously approved these changes
Nov 8, 2023
Member
|
@ramsessanchez please hold merge until the java libs are out |
andrueastman
previously approved these changes
Nov 9, 2023
baywet
previously approved these changes
Nov 13, 2023
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the work to revert from Async -> Sync for Java SDK generation we must ensure that methods do not return Completable Futures.
fixes microsoft/kiota-java#175