Skip to content

Visual Studio Build Targets for OpenAPI Reference#1190

Merged
baywet merged 27 commits intomainfrom
dm/vsext
May 5, 2022
Merged

Visual Studio Build Targets for OpenAPI Reference#1190
baywet merged 27 commits intomainfrom
dm/vsext

Conversation

@darrelmiller
Copy link
Copy Markdown
Member

@darrelmiller darrelmiller commented Feb 11, 2022

This enables Visual Studio to do compile time design generation when using the dotnet openapi tool https://docs.microsoft.com/en-us/aspnet/core/web-api/Microsoft.dotnet-openapi?view=aspnetcore-6.0

Issues #544

Also includes some additional tests because my branch management skills are poor.

Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the workflow needs to be updated to publish this package and do the code-sign + cred scan (compliance)

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@baywet
Copy link
Copy Markdown
Member

baywet commented Mar 4, 2022

another aspect is taking a dependency onto kiota so it gets installed with that extension.
and another aspect is adding entries to this enum so the UI and the dotnet CLI can call this new extension. https://github.com/dotnet/aspnetcore/blob/main/src/Tools/Microsoft.dotnet-openapi/src/CodeGenerator.cs

@baywet baywet linked an issue May 4, 2022 that may be closed by this pull request
@baywet
Copy link
Copy Markdown
Member

baywet commented May 4, 2022

TODO:

  • rename the targets package to fall under Microsoft.OpenAPI
  • rename the kiota package name to fall under Microsoft.OpenAPI
  • add ADO workflow for both packages (with credscan, code sign etc...)
  • add/update adequate workflow for mcr.microsoft.com image
  • changelog entry

@baywet baywet marked this pull request as draft May 4, 2022 19:18
@baywet baywet assigned baywet and unassigned darrelmiller May 4, 2022
Signed-off-by: Vincent Biret <[email protected]>
baywet added 4 commits May 5, 2022 09:04
@baywet
Copy link
Copy Markdown
Member

baywet commented May 5, 2022

@baywet
Copy link
Copy Markdown
Member

baywet commented May 5, 2022

Note: we're still missing the AME steps, pending on @ddyett approval for my group membership (MCR onboarders)

@baywet baywet marked this pull request as ready for review May 5, 2022 18:21
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.6% 88.6% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 8dba4cf into main May 5, 2022
@baywet baywet deleted the dm/vsext branch May 5, 2022 18:29
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generator Issues or improvements relater to generation capabilities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for dotnet OpenApiReference Release kiota image on mcr.microsoft.com and dotnet tool on nuget.org

2 participants