Skip to content

Remove enum reflection#843

Merged
baywet merged 10 commits intomicrosoft:mainfrom
andreaTP:rem-enum-reflection
Nov 22, 2023
Merged

Remove enum reflection#843
baywet merged 10 commits intomicrosoft:mainfrom
andreaTP:rem-enum-reflection

Conversation

@andreaTP
Copy link
Copy Markdown
Contributor

@andreaTP andreaTP commented Nov 21, 2023

Proposal to fix #840

baywet
baywet approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. I think we should bump the minor and release the packages as soon as the generation changes are in.

baywet
baywet requested changes Nov 21, 2023
View reviewed changes
@andreaTP
Copy link
Copy Markdown
Contributor Author

andreaTP commented Nov 21, 2023

I'm converting from Lambdas to plain classes to achieve compatibility, leave this on me @baywet if you don't mind.

@baywet
Copy link
Copy Markdown
Member

baywet commented Nov 21, 2023

I'm converting from Lambdas to plain classes to achieve compatibility, leave this on me @baywet if you don't mind.

do you mean using this syntax instead of a lambda EnumName::forValue ?

@andreaTP andreaTP force-pushed the rem-enum-reflection branch from 0c7122f to 2a045ff Compare November 21, 2023 15:09
@andreaTP
Copy link
Copy Markdown
Contributor Author

andreaTP commented Nov 21, 2023

I done the changes to make the linter happy and expanded the functional interface into a real interface, let me know if this looks good.

baywet
baywet requested changes Nov 21, 2023
View reviewed changes
andreaTP and others added 4 commits November 21, 2023 15:24
@andreaTP @baywet
Update components/abstractions/src/main/java/com/microsoft/kiota/seri…
d608598 
…alization/ValuedEnumParser.java

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@andreaTP
update changelog
54ad1c7
@andreaTP
minor
95040ab
@andreaTP
args reordering
f7fe7a6
@andreaTP
Copy link
Copy Markdown
Contributor Author

andreaTP commented Nov 21, 2023

should be good for a final review now 👍

@andreaTP
Copy link
Copy Markdown
Contributor Author

andreaTP commented Nov 21, 2023

maybe not, let me double-check, sorry for the noise.

@andreaTP andreaTP marked this pull request as draft November 21, 2023 17:19
@andreaTP andreaTP marked this pull request as ready for review November 21, 2023 17:29
@andreaTP andreaTP mentioned this pull request Nov 21, 2023
Merged
baywet
baywet approved these changes Nov 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet merged commit 1beb9ae into microsoft:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid usage of reflection API in Enum deserialization

2 participants

@andreaTP @baywet