Issue 1241: opentelemtry attribute typing error#1261
Merged
Ndiritu merged 2 commits intomicrosoft:mainfrom May 7, 2024
Merged
Conversation
…lementry attribute definition for `SERVER_PORT` from a `stringKey` to the type appropriate `longKey`.
baywet
previously requested changes
May 6, 2024
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contributions!
Can you also please:
- bump the patch version in gradle.properties
- add a changelog entry in the changelog (today's date, changed)
Contributor
Author
Updated with the requested changes. |
andrueastman
approved these changes
May 7, 2024
Ndiritu
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1241
Updating the opentelementry attribute definition for
SERVER_PORTfrom astringKeyto the type appropriatelongKey.