Changed the initialization method of the options field in BaseRequestConfiguration - #1240
Merged
Merged
Conversation
m-moris
requested review from
Ndiritu,
andrueastman,
baywet,
ramsessanchez and
zengin
as code owners
April 25, 2024 13:55
baywet
requested changes
Apr 25, 2024
baywet
left a comment
baywet
left a comment
Member
There was a problem hiding this comment.
Could you please add a unit test to prevent future regressions?
Contributor
Author
|
I have added a simple unit test, is this correct? |
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
previously approved these changes
Apr 25, 2024
baywet
left a comment
baywet
left a comment
Member
There was a problem hiding this comment.
yes that's what I expected, thank you for making the changes!
baywet
enabled auto-merge
April 25, 2024 18:45
baywet
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the initialization method of the options field in BaseRequestConfiguration from an immutable list to a mutable one.
related issue