Skip to content

Fix/content length#1119

Merged
baywet merged 7 commits intomainfrom
fix/content-length
Apr 19, 2024
Merged

Fix/content length#1119
baywet merged 7 commits intomainfrom
fix/content-length

Conversation

@Ndiritu
Copy link
Copy Markdown
Contributor

@Ndiritu Ndiritu commented Mar 18, 2024

Only override content-length with values from Content-Length header or if the body is a ByteArrayInputStream since the available() method is reliable from the array size backing the stream.

closes #1110
closes microsoftgraph/msgraph-sdk-java#1883

Pending:

  • Integration testing
  • Large File Upload Scenarios

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will take a look shortly.

@Ndiritu Ndiritu force-pushed the fix/content-length branch from e07479a to b95a6e9 Compare April 15, 2024 12:48
@Ndiritu Ndiritu changed the title WIP Fix/content length Fix/content length Apr 16, 2024
@Ndiritu Ndiritu marked this pull request as ready for review April 16, 2024 06:55
@Ndiritu Ndiritu requested a review from baywet as a code owner April 16, 2024 06:55
@Ndiritu Ndiritu force-pushed the fix/content-length branch from edc8a28 to 4143dbc Compare April 18, 2024 15:42
@sonarqubecloud
Copy link
Copy Markdown

@Ndiritu Ndiritu requested a review from baywet April 18, 2024 15:49
Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet merged commit 6bed700 into main Apr 19, 2024
@baywet baywet deleted the fix/content-length branch April 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Upload small file require Content-Length header to put method solving for content-length request header

2 participants