Fix dotnet publish // LLamaSharp conflicts#500
Merged
dluc merged 2 commits intomicrosoft:mainfrom May 18, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
LLamaSharp doesn't allow to include multiple backends at once in a packaged .NET app, requiring to build once for each backend (CPU, CUDA11, CUDA12, etc). The current code fails to "publish" due to concurring backends.
See also https://github.com/microsoft/kernel-memory/issues/498
High level description (Approach, Design)
Solve the "publish" issue by removing all LLamaSharp backends, leaving it to the end user/developer to choose one.
The need to build multiple times, once per LLamaSharp backend, persists, due to how LLamaSharp is designed. (if anyone knows of a workaround please let us know!)