You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implements batching upsert functionality in SQL Server Memory DB and updates documentation to reflect the new feature.
Code Enhancements:
Introduces the IMemoryDbBatchUpsert interface in SqlServerMemory.cs to support batch upsert operations.
Adds a new method BatchUpsertAsync for handling multiple record upserts in a batch, improving performance for bulk operations.
Modifies the UpsertAsync method to internally call BatchUpsertAsync, ensuring consistency in handling single and multiple record upserts.
Implements exception handling for batch upsert scenarios, including throwing an IndexNotFoundException when attempting to upsert to a non-existent index.
Documentation Updates:
Updates README.md in the SQL Server extension directory to include information about the new batch upsert feature.
Provides examples on how to use the BatchUpsertAsync method for efficient data insertion or updating.
Error: SqlServerMemory.cs(377,43): error CS8425: Async-iterator 'SqlServerMemory.BatchUpsertAsync(string, IEnumerable, CancellationToken)' has one or more parameters of type 'CancellationToken' but none of them is decorated with the 'EnumeratorCancellation' attribute, so the cancellation token parameter from the generated 'IAsyncEnumerable<>.GetAsyncEnumerator' will be unconsumed [/home/runner/work/kernel-memory/kernel-memory/extensions/SQLServer/SQLServer/SQLServer.csproj]
Error: SqlServerMemory.cs(377,43): error CS8425: Async-iterator 'SqlServerMemory.BatchUpsertAsync(string, IEnumerable, CancellationToken)' has one or more parameters of type 'CancellationToken' but none of them is decorated with the 'EnumeratorCancellation' attribute, so the cancellation token parameter from the generated 'IAsyncEnumerable<>.GetAsyncEnumerator' will be unconsumed [/home/runner/work/kernel-memory/kernel-memory/extensions/SQLServer/SQLServer/SQLServer.csproj]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #485
Implements batching upsert functionality in SQL Server Memory DB and updates documentation to reflect the new feature.
Code Enhancements:
IMemoryDbBatchUpsertinterface inSqlServerMemory.csto support batch upsert operations.BatchUpsertAsyncfor handling multiple record upserts in a batch, improving performance for bulk operations.UpsertAsyncmethod to internally callBatchUpsertAsync, ensuring consistency in handling single and multiple record upserts.IndexNotFoundExceptionwhen attempting to upsert to a non-existent index.Documentation Updates:
README.mdin the SQL Server extension directory to include information about the new batch upsert feature.BatchUpsertAsyncmethod for efficient data insertion or updating.For more details, open the Copilot Workspace session.