Skip to content

Fix web client base address#479

Merged
dluc merged 1 commit intomicrosoft:mainfrom
dluc:webclientbaseaddressfix
May 13, 2024
Merged

Fix web client base address#479
dluc merged 1 commit intomicrosoft:mainfrom
dluc:webclientbaseaddressfix

Conversation

@dluc
Copy link
Copy Markdown
Collaborator

@dluc dluc commented May 13, 2024

Motivation and Context (Why the change? What's the scenario?)

When deploying KM web service with a custom base address, the web client would still send requests to the default root of the endpoint (due to how .NET HttpClient merges BaseAddress and paths).

High level description (Approach, Design)

  • Add workaround for HttpClient merge of base address + path
  • Add a couple of missing await / ConfigureAwait

@dluc dluc merged commit 2a1ddd2 into microsoft:main May 13, 2024
@dluc dluc deleted the webclientbaseaddressfix branch May 13, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant