Closed
Conversation
-All tests seem to be running fine.
-All Elasticsearch pass: KM functional tests (11) and the additional ones (35)
Contributor
Author
|
I am going to merge this into the current main and then post a new PR for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
Here's the new PR with the additional tests I could not easily port yesterday.
I had to touch the Elasticsearch project, but there shouldn't be any conflict. I am not sure why it says it cannot merge automatically....
Details below.
High level description (Approach, Design)
Changes in Elasticsearch:
Elasticsearch.UnitTests
All Elasticsearch tests pass:
-DefaultTests (11)
-Additional (35)