Skip to content

Alef/simplifynugets#469

Closed
afederici75 wants to merge 15 commits intomicrosoft:mainfrom
freemindlabsinc:alef/simplifynugets
Closed

Alef/simplifynugets#469
afederici75 wants to merge 15 commits intomicrosoft:mainfrom
freemindlabsinc:alef/simplifynugets

Conversation

@afederici75
Copy link
Copy Markdown
Contributor

Motivation and Context (Why the change? What's the scenario?)

Here's the new PR with the additional tests I could not easily port yesterday.
I had to touch the Elasticsearch project, but there shouldn't be any conflict. I am not sure why it says it cannot merge automatically....
Details below.

High level description (Approach, Design)

Changes in Elasticsearch:

-Removed all Free Mind Labs, Inc. copyright in both extension and test project.
-Refactored IndexNameHelper and turned it into a static class. This removed a lot of unnecessary complexity and arguments.
-Adjusted ElasticsearchMemoryDb to the changes in IndexNameHelper.	

Elasticsearch.UnitTests

-Removed Usings.cs
-Created MemoryDbFunctionalTest which descends from KM's BaseFunctionalTestCase, thus providing access to configuration and other common things.
-Refactored all tests to inherit from MemoryDbFunctionalTest and be consitent with KM's.	

All Elasticsearch tests pass:
-DefaultTests (11)
-Additional (35)

@afederici75 afederici75 requested a review from dluc as a code owner May 8, 2024 20:03
@afederici75 afederici75 closed this May 9, 2024
@afederici75
Copy link
Copy Markdown
Contributor Author

I am going to merge this into the current main and then post a new PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant