Skip to content

Conversation

@elweb9858
Copy link
Contributor

@elweb9858 elweb9858 commented Apr 16, 2020

When session affinity support was added to hcsshim via LoadBalancerDistribution field, an incorrect version check was established. This PR correctly lines up hcsshim with the release of the LoadBalancerDistribution platform work in HNS.

@elweb9858
Copy link
Contributor Author

@madhanrm PTAL

@elweb9858
Copy link
Contributor Author

@microsoft/containerplat - PTAL

@katiewasnothere
Copy link

Hi, can you update the description of this PR to give some background on this change? Additionally, we ask that contributors please sign all commits.

@elweb9858 elweb9858 force-pushed the sessionaffinity_versioncheck branch from 58069de to f2f6248 Compare April 16, 2020 19:11
@elweb9858
Copy link
Contributor Author

@katiewasnothere thanks for the quick response. I've added a description & signed the commit

Copy link

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcantah dcantah merged commit 7ffb5b1 into microsoft:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants