Skip to content

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Aug 15, 2023

Previous Behavior

New Behavior

  1. restructure to ensure no leak of logic from state hook to render method
  2. flats all slots into type declaration and uses composition API

Related Issue(s)

@bsunderhus bsunderhus self-assigned this Aug 15, 2023
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 15, 2023
@bsunderhus bsunderhus marked this pull request as ready for review August 15, 2023 11:38
@bsunderhus bsunderhus requested a review from a team as a code owner August 15, 2023 11:38
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 15, 2023

📊 Bundle size report

🤖 This report was generated against d73590f34a41a22776a0bc2c41391b589531e679

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e63a3a9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 15, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d73590f34a41a22776a0bc2c41391b589531e679 (build)

@bsunderhus bsunderhus requested a review from smhigley August 16, 2023 08:14
@bsunderhus bsunderhus force-pushed the react-search-preview/chore--migrate-to-new-slots-API branch from 096e857 to 2839ea7 Compare August 17, 2023 09:35
@bsunderhus bsunderhus requested a review from khmakoto August 17, 2023 12:05
@@ -0,0 +1,7 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smhigley @khmakoto , can you verify the Visual Regressions?!

@bsunderhus bsunderhus force-pushed the react-search-preview/chore--migrate-to-new-slots-API branch from 2839ea7 to e63a3a9 Compare August 17, 2023 20:18
@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus merged commit d7743e6 into microsoft:master Aug 18, 2023
@bsunderhus bsunderhus deleted the react-search-preview/chore--migrate-to-new-slots-API branch August 18, 2023 07:09
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 21, 2023
* master:
  fix(react-drawer): rename values of position prop from left/right to start/end (microsoft#28905)
  Breadcrumb design team fixes (microsoft#28883)
  applying package updates
  chore(react-search-preview): migrate to new slots API (microsoft#28862)
  docs: Updating version of CDN used and replacing usage of via.placeholder.com with SVG from CDN (microsoft#28895)
  fix(DatePicker, react-datepicker-compat): Make year picker react to go to today button (microsoft#28907)
  fix(DatePicker): readOnlyTextField styles should win over default TextField's (microsoft#28891)
  chore: fix lint warnings for @fluentui/react (microsoft#28888)
  Lint: fix fluent v9 warnings (microsoft#28889)
  doc: add drag & drop example (microsoft#28821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore]: migrate react-search to new slot API

3 participants