Repository navigation
Await backend operations before acknowledging test-host hub creation/deletion - #813
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fcb29286-7b10-46c3-b14c-ef50314874e5
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation correctly addresses premature acknowledgements and is comprehensively covered by deterministic tests.
0 open findings
What changed in this PR
Ensures test-host task-hub lifecycle RPCs acknowledge requests only after backend completion and propagate failures.
Changes:
- Await backend create/delete operations.
- Add 12 regression cases covering completion, failures, and recreation options.
| File | Description |
|---|---|
src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs |
Awaits lifecycle operations before responding. |
test/InProcessTestHost.Tests/HubLifecycleTests.cs |
Tests pending, completed, and failed operations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
kaibocai (kaibocai)
approved these changes
Oct 9, 2026
Merged
1 of 15 tasks
This was referenced Oct 27, 2026
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the in-process test host acknowledge task-hub creation and deletion only after the backend operation succeeds.
What changed?
CreateTaskHubandDeleteTaskHubbefore returning their existing empty responses.RecreateIfExistsvalues.Why is this change needed?
Issues / work items
Project checklist
release_notes.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
src\InProcessTestHost\Sidecar\Grpc\TaskHubGrpcServer.csandtest\InProcessTestHost.Tests\HubLifecycleTests.cs.AI verification (required if AI was used):
Testing
Automated tests
dotnet test .\test\InProcessTestHost.Tests\InProcessTestHost.Tests.csproj --configuration Release --framework net10.0 --no-build --no-restore --filter 'FullyQualifiedName~InProcessTestHost.Tests.HubLifecycleTests' --verbosity minimaldotnet test .\test\InProcessTestHost.Tests\InProcessTestHost.Tests.csproj --configuration Release --framework net10.0 --no-build --no-restore --verbosity minimaldotnet build .\src\InProcessTestHost\InProcessTestHost.csproj --configuration Release --no-restore --verbosity quietgit --no-pager diff --check origin/main...HEADBefore the fix, the lifecycle selector produced 9 expected failures: 3 premature acknowledgements and 6 swallowed backend failures. The 3 already-completed success cases passed. The final committed change passes all 12 cases.
Full-repository validation and emulator/cloud-dependent suites were not run.
Manual validation (only if runtime/behavior changed)
Notes for reviewers