-
Notifications
You must be signed in to change notification settings - Fork 5
Partner integration cli update #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Created comprehensive CLI tool for Partner Integration development - Includes init, generate, validate, and package commands - Supports EHR, API connector, data sync, and custom templates - Full test coverage with Jest (10/10 tests passing) - Based on Dragon Extension CLI architecture - Cross-platform support (Windows, macOS, Linux) - Production-ready with error handling and validation
Co-authored-by: mfrongillo35 <[email protected]>
Co-authored-by: mfrongillo35 <[email protected]>
Co-authored-by: mfrongillo35 <[email protected]>
…views Add CODEOWNERS and branch protection documentation
- Create comprehensive setup guide for users without VS Code - Include cross-platform instructions for Windows, Linux, and Mac - Cover CLI installation, partner initialization, and troubleshooting - Provide alternative installation methods and common solutions
- Changed partner integration output from integration.yaml to extension.yaml - Updated publisher schema scope from ['Workflow', 'US'] to ['Workflow', 'EHR Connector'] - Updated all CLI command references from legacy format to unified dragon-copilot structure: - partner-integration commands -> dragon-copilot partner commands - dragon-extension commands -> dragon-copilot extension commands - Fixed non-existent add-tool command references to use generate --interactive - Updated web interface placeholder text for better UX - All tests passing and CLI structure verified
- Changed partner integration CLI defaults to improve UX: * Allow multiple issuers for client authentication: No (was Yes) * Collect user identity claim: No (was Yes) * Include Interop context values: No (was Yes) - Fixed web interface Context Retrieval section: * Removed auto-loading of base_url, in-bound-client-id, out-bound-client-id * Context retrieval now starts empty, requires manual addition - Enhanced Clinical Application Name guidance: * Updated tooltip: 'Often the EHR or EMR name' * Updated accessibility labels with complete description - Made Server Authentication Issuer required: * Removed '(optional)' from Issuer URL field label * Added required asterisk (*) indicator * Updated tooltip text to reflect it's required * Added validation to ensure issuer URL is not empty * Improved error messaging for missing issuer fields All tests passing and CLI functionality verified
…LONE_SETUP.md - Added detailed Step 1 and Step 2 sections for installing Node.js, npm, and .NET - Included platform-specific instructions (Windows, macOS, Linux) - Provided multiple installation methods (official downloads, package managers, nvm) - Added PowerShell, Chocolatey, Winget, Homebrew, apt, dnf installation options - Updated section numbering throughout document (Steps 3-8) - Enhanced troubleshooting section with reference to detailed installation steps - Included verification commands for confirming successful installation - Improved user experience for standalone setup without VS Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request consolidates and standardizes the Dragon Copilot CLI tooling by renaming dragon-extension-cli to dragon-copilot-cli and introducing support for partner integration workflows alongside existing extension workflows. The changes include complete deletion of the old CLI structure, addition of new partner-specific commands, web-based manifest builder, shared validation utilities, and enhanced repository security documentation.
Key Changes:
- Complete removal of the legacy
dragon-extension-cliimplementation (all source files, tests, configuration) - Introduction of unified
dragon-copilot-cliwith domain-separated architecture (extensionandpartnerdomains) - Addition of web-based manifest builder with drag-and-drop UI for partner integrations
- Enhanced schema validation supporting both extension and partner manifest formats (v3)
- New repository security documentation (CODEOWNERS, branch protection checklist)
Reviewed Changes
Copilot reviewed 76 out of 217 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
tools/dragon-extension-cli/** |
Complete deletion of legacy CLI implementation |
tools/dragon-copilot-cli/src/domains/partner/** |
New partner integration domain with commands, types, templates, and validation |
tools/dragon-copilot-cli/src/domains/extension/** |
Updated extension domain with manifest v3 support |
tools/dragon-copilot-cli/src/common/** |
Shared utilities for logging, logo validation, assets, and publisher prompts |
tools/dragon-copilot-cli/src/shared/schema-validator.ts |
Unified schema validator for both extension and partner manifests |
tools/dragon-copilot-cli/web/** |
Web-based manifest builder with 1800+ lines of JavaScript and CSS |
tools/dragon-copilot-cli/src/schemas/** |
JSON schemas for extension, partner, and publisher configurations |
tools/dragon-copilot-cli/tsconfig.json |
TypeScript configuration for the unified CLI |
Files not reviewed (1)
- tools/dragon-copilot-cli/package-lock.json: Language not supported
tools/dragon-copilot-cli/src/domains/partner/shared/context-items.ts
Outdated
Show resolved
Hide resolved
tools/dragon-copilot-cli/src/domains/partner/shared/context-items.ts
Outdated
Show resolved
Hide resolved
tools/dragon-copilot-cli/src/domains/partner/shared/context-items.ts
Outdated
Show resolved
Hide resolved
tools/dragon-copilot-cli/src/domains/partner/shared/context-items.ts
Outdated
Show resolved
Hide resolved
|
@microsoft-github-policy-service agree company="Microsoft" |
…ems.ts Co-authored-by: Copilot <[email protected]>
…ems.ts Co-authored-by: Copilot <[email protected]>
…ems.ts Co-authored-by: Copilot <[email protected]>
…ems.ts Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
| export declare const blue: (value: unknown) => string; | ||
| export declare const gray: (value: unknown) => string; | ||
| export declare const green: (value: unknown) => string; | ||
| export declare const red: (value: unknown) => string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing you didn't want to include the dist/ folder + files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that's my bad. I had git Copilot run the pull request and didn't have it remove the test files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 76 out of 217 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- tools/dragon-copilot-cli/package-lock.json: Language not supported
This pull request introduces several documentation updates and configuration improvements to standardize tooling, enhance repository security, and clarify setup instructions. The most significant changes are the consolidation of CLI tooling under
dragon-copilot-cli, the addition of branch protection and code owner documentation, and expanded setup guides for both standard and standalone environments.Tooling and CLI Standardization
dragon-extension-clitodragon-copilot-cliin documentation, CI workflows, and Dependabot configuration, reflecting the unified CLI for both extension and partner workflows. The new CLI supports manifest version 3 with automation scripts, event triggers, and dependency metadata. (README.md[1] [2] [3] [4]QUICKSTART.md[5]QUICKSTART.md[1]STANDALONE_SETUP.md[2]Repository Security and Branch Protection
.github/CODEOWNERS[1].github/BRANCH_PROTECTION_CHECKLIST.md[2]README.mdREADME.mdR67-R78)Documentation Improvements
STANDALONE_SETUP.md) detailing platform-specific installation steps for Node.js, .NET, and the CLI, including troubleshooting and usage without VS Code.doc/Authentication.md[1]doc/AuthenticationDesign.md[2]Other Minor Updates
QUICKSTART.mdQUICKSTART.mdR1)These changes collectively improve the developer onboarding experience, enforce repository security best practices, and ensure consistency across documentation and automation workflows.