fix: merge from dev changes to main #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: update SampleQuestions.md with new content
Thanusree-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
malrose07 and
toherman-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds a note about expected response times to the sample questions documentation. The update informs users that they should expect responses within 7-16 seconds when using the application.
- Added a response time expectation note to help set user expectations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: fix AI Foundry resource ID output logic
…caling during WAF deployment
… during WAF deployment
fix: reduced the replica instance count to 1 for WAF version
Roopan-Microsoft
changed the title
Roopan-Microsoft
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the infrastructure deployment templates to use the latest Azure API version and Bicep tooling, and refines the web server farm configuration for WAF deployments. It also makes minor documentation improvements. The most important changes are grouped below.
Infrastructure Template Updates
infra/main.jsonto use API version2025-04-01instead of2022-09-01, ensuring compatibility with the latest Azure features and resource types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]infra/main.jsonto reflect the new tooling version (0.38.33.27573). [1] [2] [3] [4] [5] [6]Web Server Farm Configuration
skuCapacityfor web server farm deployments in bothinfra/main.bicepandinfra/main.jsonto always be1, with explanatory comments about multiple agents per type during WAF deployment. This ensures correct scaling behavior for WAF scenarios. [1] [2]Resource Output and Reference Fixes
AI_FOUNDRY_RESOURCE_IDininfra/main.bicepto use the correct property (existingAiFoundryAiServices.id) when using an existing AI Foundry project.infra/main.jsonto use the new API version for storage and CosmosDB keys.Dependency Ordering
infra/main.jsonto ensure proper resource provisioning sequence. [1] [2]Documentation
docs/SampleQuestions.mdfor improved user guidance.Does this introduce a breaking change?
Other Information
Added average response time in Samplequestion.md.