Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@JhontSouth
Copy link
Collaborator

Fixes #6798

Description

This PR allows the use of Token Credentials to authenticate and create an instance of BlobsTranscriptStore.

Specific Changes

  • Added constructors in BlobsTranscriptStore with blobServiceUri and tokenCredentials as parameters.
  • Added constructor validations in unit tests.

Testing

The following images show the bot working and saving transcripts using BlobsTranscriptStore instantiated with token credentials.
image
image

@JhontSouth JhontSouth requested a review from a team as a code owner July 8, 2024 14:29
@tracyboehrer tracyboehrer added Automation: Parity with js The PR needs to be ported to JS Automation: Parity with python The PR needs to be ported to Python labels Jul 8, 2024
@tracyboehrer tracyboehrer merged commit 1e6eb61 into main Jul 8, 2024
@tracyboehrer tracyboehrer deleted the southworks/add/blobtranscriptstore-token-credential branch July 8, 2024 18:45
tracyboehrer added a commit that referenced this pull request Sep 10, 2024
* Fix for Skills endorsement check (#6846)

Co-authored-by: Tracy Boehrer <[email protected]>

* FederatedAppCredentials and factory

* add token credential authentication to BlobsTranscriptStore (#6813)

* [#6741] Remove .Net Core 3.1 from projects (#6819)

* Remove netcoreapp3.1 and fix System.Text.Json issue

* Fix System.Formats.Asn1 security issue

* Fix remaining System.Text.Json issue

* Removed unused argument from FederatedAuthenticator.CreateClientApplication

* Fix Microsoft.Bcl.AsyncInterfaces warning (#6837)

# Conflicts:
#	libraries/Microsoft.Bot.Builder.Azure/Microsoft.Bot.Builder.Azure.csproj

* add code ql comment about TypeNameHandling.None (#6843)

---------

Co-authored-by: Tracy Boehrer <[email protected]>
Co-authored-by: Jhonatan Sandoval Velasco <[email protected]>
Co-authored-by: Joel Mut <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS Automation: Parity with python The PR needs to be ported to Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to create instance of BlobsTranscriptStore using TokenCredential instead of connectionString and containerName

3 participants