Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@ceciliaavila
Copy link
Collaborator

Addresses #6741
#minor

Description

This PR updates the test projects, the test bots, and the CI pipelines to target .NET 8.
All these changes need to be done in one PR for the build checks to pass.
We divided the changes into three commits to ease the review:

Note: The FunctionalTests pipelines and the generators will be updated in separate PRs.

Specific Changes

  • For the test projects:

    • Update projects to target net8.0 as well as net6.0.
    • Removed any conditions considering frameworks lower than .NET5.
    • Fixed CS8981 issue in Microsoft.Bot.Builder.Dialogs.Adaptive.Tests/ConditionalsTests
  • For the bots projects:

    • Updated all the bots to target .NET8 instead of .NET6.
  • For the CI pipelines yamls:

    • Added steps to build and test targeting .NET8.
    • Removed steps to build and test targeting netcoreapp3.1.

Testing

This image shows the TestBot bots working as expected after the update.
image

Here we can see the CI pipeline working after the changes.
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Mar 11, 2024
@ceciliaavila ceciliaavila requested a review from a team as a code owner March 11, 2024 14:26
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 389178

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.157%

Totals Coverage Status
Change from base Build 388884: 0.0%
Covered Lines: 26178
Relevant Lines: 33494

💛 - Coveralls

@tracyboehrer
Copy link
Member

@ceciliaavila If it doesn't cause any issues, lets retain the 3.1 support in the packages.

@ceciliaavila
Copy link
Collaborator Author

@ceciliaavila If it doesn't cause any issues, lets retain the 3.1 support in the packages.

Sure, we'll update the projects to keep supporting netcoreapp 3.1.

@tracyboehrer
Copy link
Member

@ceciliaavila @sw-joelmut Were the changes to retain 3.1 support (if possible) made?

@sw-joelmut
Copy link
Collaborator

Hi @tracy, we prioritized other issues over this, but we can address it next week.

@tracyboehrer
Copy link
Member

tracyboehrer commented Apr 19, 2024 via email

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

@JhontSouth
Copy link
Collaborator

Hi @tracyboehrer, the changes to maintain support for Net Core 3.1 are ready in the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants