Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@ceciliaavila
Copy link
Collaborator

#minor

Description

This PR adds the sendx5c parameter to the CertificateServiceClientCredentialsFactory and MsalAppCredentials classes.

Specific Changes

  • Added sendx5c parameter to the CertificateServiceClientCredentialsFactory class into a new constructor.
  • Added sendx5c parameter to the MsalAppCredentials class into a new constructor.
  • Updated CertificateServiceClientCredentialsFactoryTests to cover the new constructor.
  • Added MsalServiceClientCredentialsFactoryTests test class.

Testing

This image shows the new tests passing.
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Oct 11, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner October 11, 2023 19:26
@ceciliaavila ceciliaavila marked this pull request as draft October 11, 2023 19:41
@ceciliaavila
Copy link
Collaborator Author

Converting to draft while reviewing #6694

@coveralls
Copy link
Collaborator

coveralls commented Oct 11, 2023

Pull Request Test Coverage Report for Build 372341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.06%) to 73.511%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Connector/Authentication/MsalAppCredentials.cs 45 12.22%
Totals Coverage Status
Change from base Build 371560: 0.06%
Covered Lines: 24174
Relevant Lines: 32885

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@ceciliaavila ceciliaavila marked this pull request as ready for review October 12, 2023 14:02
@ceciliaavila
Copy link
Collaborator Author

Hi @tracyboehrer , we reverted the changes to CertificateServiceClientCredentialsFactory as they were addressed in #6694. We kept the changes to MsalAppCredentials and the new unit tests.

@tracyboehrer tracyboehrer merged commit 617394d into main Oct 12, 2023
@tracyboehrer tracyboehrer deleted the southworks/add/sendx5c-parameter-to-factory branch October 12, 2023 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants