Skip to content

Conversation

@dmcilvaney
Copy link
Contributor

@dmcilvaney dmcilvaney commented Apr 1, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

openjade doesn't seem to be actively updated anymore, and is used in only one specific package: docbook-style-dsss, which intern is also used by only one package: freetds to produce reference examples.

If we configure freetds to build without doxygen it won't require the above packages. There are however a few packges in SPECS-EXTENDED that still use them, so instead of removing them just move them back. (They were moved in when php was promoted #3820).

Change Log
  • Demote openjade to SPECS-EXTENDED
  • Demote docbook-style-dsssl to SPECS-EXTENDED
  • Configure freetds to build without needed docbook-style-dsss.
Does this affect the toolchain?

NO

Test Methodology

@dmcilvaney dmcilvaney requested a review from a team as a code owner April 1, 2024 23:31
@dmcilvaney dmcilvaney added the 3.0-dev PRs Destined for AzureLinux 3.0 label Apr 4, 2024
Copy link
Collaborator

@jslobodzian jslobodzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if we can demonstrate no impact to the core packages build or run time.

@dmcilvaney
Copy link
Contributor Author

@dmcilvaney dmcilvaney merged commit 8c27aa2 into microsoft:3.0-dev Apr 12, 2024
@dmcilvaney dmcilvaney deleted the damcilva/3.0/upgrades/openjade branch April 12, 2024 17:55
Xiaohong-Deng pushed a commit to Xiaohong-Deng/azurelinux that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants