Skip to content

Conversation

@oliviacrain
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

node-problem-detector had a test regression after mariner-release was removed from the worker chroot. Adding it in as a check-time/run-time dependency to fix tests and ensure functionality.

Change Log
  • node-problem-detector: Add explicit check/run-time dependencies on mariner-release
Does this affect the toolchain?

NO

Test Methodology
  • Buddy build pipeline 199731

@oliviacrain oliviacrain requested a review from a team as a code owner June 1, 2022 19:08
@ghost ghost added Packaging main PR Destined for main labels Jun 1, 2022
@oliviacrain oliviacrain merged commit 8c8298b into main Jun 1, 2022
@oliviacrain oliviacrain deleted the olivia/npdtestfix branch June 1, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants