Skip to content

Conversation

@oliviacrain
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

#2630 caused a build break due to a change to the cmake call in dnf-plugins-core. The change caused cmake to be given python3 instead of the desired file path /usr/bin/python3. This caused the build of dnf-plugins-core to fail, since the cmake script expects either a major version number or a file path.

This PR changes the cmake call to use the full python3 binary file path.\

Cherry-pick of #2658.

Change Log
  • dnf-plugins-core: Pass cmake the file path of our python3 binary to fix build
  • dnf-plugins-core: no changelog entry/release bump, since this release has not been published
Does this affect the toolchain?

NO

Test Methodology
  • N/A

@oliviacrain oliviacrain requested a review from a team as a code owner April 4, 2022 16:23
@ghost ghost added Packaging main PR Destined for main labels Apr 4, 2022
@oliviacrain oliviacrain merged commit 950bef4 into main Apr 4, 2022
@oliviacrain oliviacrain deleted the olivia/main-fix-dnfplug branch April 4, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants