Skip to content

Conversation

@PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Feb 4, 2022

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

A cherry-pick of a main branch tooling fix from #2091.

Change Log
Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • Local package and image builds.

@PawelWMS PawelWMS requested a review from jslobodzian February 4, 2022 00:48
@jslobodzian jslobodzian merged commit 22d85d8 into microsoft:2.0 Feb 4, 2022
@PawelWMS PawelWMS deleted the pawelwi/cp_tooling_fix branch March 2, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants