Skip to content

Upgrade valkey to 8.0.6 for CVE-2025-49844 CVE-2025-46817 CVE-2025-46818 CVE-2025-46819 #14835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

Upgrade valkey to 8.0.6 for CVE-2025-49844 CVE-2025-46817 CVE-2025-46818 CVE-2025-46819 #14835

merged 1 commit into from
Oct 8, 2025
+19 −95

Conversation

@Kanishk-Bansal
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal commented Oct 8, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Does this affect the toolchain?

YES/NO

Associated issues
Summary

What does the PR accomplish, why was it needed?
Total CVEs processed: 4

  • Address CVE-2025-49844, CVE-2025-46817, CVE-2025-46818, CVE-2025-46819
Change Log
  • CVE-2025-49844,
  • CVE-2025-46817,
  • CVE-2025-46818,
  • CVE-2025-46819,
Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/3.0 PRs Destined for Azure Linux 3.0 labels Oct 8, 2025
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/valkey/8.0.6 branch from 06105fa to ad54660 Compare October 8, 2025 06:44
Kanishk-Bansal
Kanishk-Bansal commented Oct 8, 2025
View reviewed changes
SPECS/valkey/valkey.spec
Group: Applications/Databases
URL: https://valkey.io/
Source0: https://github.com/valkey-io/valkey/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz
Patch0: valkey-conf.patch
Copy link
Contributor Author

@Kanishk-Bansal Kanishk-Bansal Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valkey-conf.patch is incorporated in 8.0.6

Kanishk-Bansal
Kanishk-Bansal commented Oct 8, 2025
View reviewed changes
SPECS/valkey/valkey.spec
Source0: https://github.com/valkey-io/valkey/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz
Patch0: valkey-conf.patch
Patch1: disable-mem-defrag-tests.patch
Patch2: CVE-2025-49112.patch
Copy link
Contributor Author

@Kanishk-Bansal Kanishk-Bansal Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is fixed in 8.0.6 with valkey-io/valkey#2101

Kanishk-Bansal
Kanishk-Bansal commented Oct 8, 2025
View reviewed changes
SPECS/valkey/valkey.spec
Patch0: valkey-conf.patch
Patch1: disable-mem-defrag-tests.patch
Patch2: CVE-2025-49112.patch
Patch3: CVE-2025-27151.patch
Copy link
Contributor Author

@Kanishk-Bansal Kanishk-Bansal Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also fixed by valkey-io/valkey#2146 in 8.0.6
valkey-io/valkey@8.0.4...8.0.6

Kanishk-Bansal
Kanishk-Bansal commented Oct 8, 2025
View reviewed changes
SPECS/valkey/valkey.spec
Patch1: disable-mem-defrag-tests.patch
Patch2: CVE-2025-49112.patch
Patch3: CVE-2025-27151.patch
Patch0: disable-mem-defrag-tests.patch
Copy link
Contributor Author

@Kanishk-Bansal Kanishk-Bansal Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified some hunks

@Kanishk-Bansal
Copy link
Contributor Author

Kanishk-Bansal commented Oct 8, 2025

Valkey 8.0.6
Upgrade urgency SECURITY: This release includes security fixes we recommend you
apply as soon as possible.

Security fixes
(CVE-2025-49844) A Lua script may lead to remote code execution
(CVE-2025-46817) A Lua script may lead to integer overflow and potential RCE
(CVE-2025-46818) A Lua script can be executed in the context of another user
(CVE-2025-46819) LUA out-of-bound read

Bug fixes
Fix accounting for dual channel RDB bytes in replication stats (valkey-io/valkey#2616)
Minor fix for dual rdb channel connection conn error log (valkey-io/valkey#2658)
Fix unsigned difference expression compared to zero (valkey-io/valkey#2101)

@Kanishk-Bansal Kanishk-Bansal marked this pull request as ready for review October 8, 2025 08:35
@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner October 8, 2025 08:35
@Kanishk-Bansal Kanishk-Bansal added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Oct 8, 2025
@realsdx
Copy link
Contributor

realsdx commented Oct 8, 2025

Buddy Build url is wrong @Kanishk-Bansal

@PawelWMS PawelWMS mentioned this pull request Oct 8, 2025
Merged
12 tasks
PawelWMS
PawelWMS approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. The failing circular check is bogus and it's a bug in the PR check itself. Fixing the PR check separately in #14841. Used #14840 to verify that the fix works and the check turns green with these changes inside it.

Merging.

@PawelWMS PawelWMS merged commit e32a4e4 into fasttrack/3.0 Oct 8, 2025
30 of 32 checks passed
@PawelWMS PawelWMS deleted the kanbansal/valkey/8.0.6 branch October 8, 2025 22:58
CBL-Mariner-Bot pushed a commit that referenced this pull request Oct 8, 2025
@Kanishk-Bansal @CBL-Mariner-Bot
Upgrade valkey to 8.0.6 for CVE-2025-49844 CVE-2025-46817 CVE-2025-…
0f54bd7 
…46818 CVE-2025-46819 (#14835)

Signed-off-by: Kanishk Bansal <[email protected]>
Co-authored-by: Kanishk Bansal <[email protected]>
(cherry picked from commit e32a4e4)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Oct 8, 2025
Merged
@CBL-Mariner-Bot
Copy link
Collaborator

CBL-Mariner-Bot commented Oct 8, 2025

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=949126&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PawelWMS PawelWMS PawelWMS approved these changes

Assignees

No one assigned

Labels

CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review fasttrack/3.0 PRs Destined for Azure Linux 3.0 Packaging security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kanishk-Bansal @realsdx @CBL-Mariner-Bot @PawelWMS