Repository navigation
[release/13.4] Remove 'aspire new aspire-starter' step from CLI archive verifier - #17646
Conversation
The signed-build verifier ran 'aspire new aspire-starter' after extracting the CLI archive, claiming to exercise 'template engine + bundle self-extraction without requiring a NuGet restore'. That claim was wrong: 'aspire new' resolves template versions via TemplateNuGetConfigService.ResolveTemplatePackageAsync, which always queries a NuGet feed. The step only ever succeeded on release branches because builds were mis-baked with AspireCliChannel=stable, which routed the implicit identity-channel lookup to nuget.org and found a previously-shipped Aspire.ProjectTemplates version. Once #17528 corrected the release-branch builds to bake AspireCliChannel=staging, the identity channel switched to a staging feed that is not reachable from the 1ES signed-build agent, and the step started failing with 'No template versions were found' in the internal build pipeline. This is the same egress reason the TypeScript starter check was already removed for (#17274, tracked in #17345). Re-adding meaningful starter coverage in the signed-build verifier requires either an internal NuGet mirror or a no-network template path. Drop the step (and the corresponding test assertion); the verifier still covers archive layout, sidecar contract, and 'aspire --version' execution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17646Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17646" |
There was a problem hiding this comment.
Pull request overview
Backport to release/13.4 that removes the aspire new aspire-starter step from the signed-build CLI archive verifier. The step depended on NuGet feed reachability (template lookup goes through TemplateNuGetConfigService.ResolveTemplatePackageAsync), which broke after #17528 corrected release-branch builds to bake AspireCliChannel=staging — the staging feed is unreachable from the 1ES signed-build agent.
Changes:
- Remove
Test-CSharpStarterProjecthelper and its invocation fromverify-cli-archive.ps1, replaced with an explanatory comment. - Update docstring to drop the starter creation step.
- Drop the corresponding assertion in
VerifyCliArchivePowerShellTests.cs.
Show a summary per file
| File | Description |
|---|---|
eng/scripts/verify-cli-archive.ps1 |
Removes the C# starter project test step and helper; adds a rationale comment. |
tests/Aspire.Acquisition.Tests/Scripts/VerifyCliArchivePowerShellTests.cs |
Removes the assertion checking starter-project success output. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
|
✅ No documentation update needed. docs_required → already documented by name Triggered signals (1): Evidence: The PR body mentions Per-signal documentation coverage:
This PR is a pure CI/build-script change ( |
Description
The signed-build CLI archive verifier (
eng/scripts/verify-cli-archive.ps1) was runningaspire new aspire-starterafter extracting the archive. Its docstring claimed this exercised "template engine + bundle self-extraction without requiring a NuGet restore" — but that claim is wrong.aspire newresolves template versions viaTemplateNuGetConfigService.ResolveTemplatePackageAsync, which always queries a NuGet feed.Why it used to work
On release branches, this step only ever passed by accident. Pre-#17528, release-branch builds were mis-baked with
AspireCliChannel=stable. With astableidentity channel,NewCommand.ResolveCliTemplateVersionAsyncroutes the lookup to nuget.org (thestablechannel maps*→nuget.org), where a previously-shippedAspire.ProjectTemplatesversion was always available. So the verifier appeared to succeed, but it was actually depending on:Why it now fails
#17528 corrected release-branch builds to bake
AspireCliChannel=staging(so dogfood drops aren't mis-identified as stable). With astagingidentity channel, the implicit selection inNewCommand(seeResolveCliTemplateVersionAsync, NewCommand.cs:333-345) now picks the staging channel, which mapsAspire*to a SHA-specific darc-pub feed (or the shared daily feed). That feed is not reachable from the 1ES signed-build agent, so the lookup returns nothing and the verifier fails with:This is the same egress reason the TypeScript starter check was already removed for in #17274 (tracked in #17345).
Change
Test-CSharpStarterProjectinvocation and helper fromeng/scripts/verify-cli-archive.ps1, with a comment explaining the rationale.VerifyCliArchivePowerShellTests.cs.aspire newhandler inFakeArchiveHelperalone — it's harmless mock code and avoids unnecessary diff churn.The verifier still covers archive layout (sidecar contract for per-RID archives), CLI extraction, and
aspire --versionexecution. Re-adding meaningful starter coverage in the signed-build verifier requires either an internal NuGet mirror configured on the agent or a no-network template path.Fixes the internal AzDO build break introduced by #17528.
Checklist
VerifyCliArchive_AcceptsCleanPerRidArchiveadjusted; sidecar tests unaffected).