Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
<!-- Issue: https://github.com/microsoft/aspire/issues/10175 -->
<!-- NU1510: The project does not reference any target framework and will not be restored. -->
<!-- TODO: Re-enable and remove this. -->
<!-- ASPIREATS001: Aspire Type System APIs are experimental -->
<NoWarn>$(NoWarn);xUnit1051;NU1510;ASPIREATS001</NoWarn>
<NoWarn>$(NoWarn);xUnit1051;NU1510</NoWarn>
</PropertyGroup>

<!-- OS/Architecture properties for local development resources -->
Expand Down
1 change: 0 additions & 1 deletion src/Aspire.Hosting.Blazor/BlazorGatewayExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

#pragma warning disable ASPIREDOCKERFILEBUILDER001 // DockerfileBuilder is experimental
#pragma warning disable ASPIRECSHARPAPPS001 // AddCSharpApp is experimental
#pragma warning disable ASPIREATS001 // AspireExportIgnore is experimental

namespace Aspire.Hosting;

Expand Down
2 changes: 0 additions & 2 deletions src/Aspire.Hosting.Blazor/BlazorHostedExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
using Aspire.Hosting.ApplicationModel;
using Microsoft.Extensions.Logging;

#pragma warning disable ASPIREATS001 // AspireExportIgnore is experimental

namespace Aspire.Hosting;

/// <summary>
Expand Down
2 changes: 0 additions & 2 deletions src/Aspire.Hosting.Blazor/Resources/BlazorWasmAppResource.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#pragma warning disable ASPIREATS001 // AspireExport is experimental

using System.Diagnostics.CodeAnalysis;
using Aspire.Hosting.ApplicationModel;

Expand Down
6 changes: 0 additions & 6 deletions src/Aspire.Hosting.CodeGeneration.Go/AssemblyInfo.cs

This file was deleted.

6 changes: 0 additions & 6 deletions src/Aspire.Hosting.CodeGeneration.Java/AssemblyInfo.cs

This file was deleted.

6 changes: 0 additions & 6 deletions src/Aspire.Hosting.CodeGeneration.Python/AssemblyInfo.cs

This file was deleted.

6 changes: 0 additions & 6 deletions src/Aspire.Hosting.CodeGeneration.Rust/AssemblyInfo.cs

This file was deleted.

6 changes: 0 additions & 6 deletions src/Aspire.Hosting.CodeGeneration.TypeScript/AssemblyInfo.cs

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<PackageReadmeFile>README.md</PackageReadmeFile>
<PackageTags>aspire hosting analyzers ats polyglot integration</PackageTags>
<Description>Experimental analyzers for Aspire hosting integration authors.</Description>
<Description>Analyzers for Aspire hosting integration authors.</Description>
<LangVersion>12.0</LangVersion>
<!--
Analyzer projects don't need XML docs
Expand Down
4 changes: 2 additions & 2 deletions src/Aspire.Hosting.Integration.Analyzers/README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Aspire.Hosting.Integration.Analyzers package

Provides experimental Roslyn analyzers for Aspire hosting integration authors building ATS and polyglot-friendly extensions outside the Aspire repo.
Provides Roslyn analyzers for Aspire hosting integration authors building ATS and polyglot-friendly extensions outside the Aspire repo.

## Getting started

### Install the package

In your integration project, install the experimental analyzer package with [NuGet](https://www.nuget.org):
In your integration project, install the analyzer package with [NuGet](https://www.nuget.org):

```dotnetcli
dotnet add package Aspire.Hosting.Integration.Analyzers --prerelease
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

namespace Aspire.Hosting.ApplicationModel;

/// <summary>
Expand All @@ -14,7 +12,6 @@ namespace Aspire.Hosting.ApplicationModel;
/// to route references to resource-specific logic at runtime. Implementations may
/// customize dispatch based on either the source or destination resource type.
/// </remarks>
[Experimental("ASPIREATS001")]
public interface IResourceWithCustomWithReference<TSelf> : IResource
where TSelf : IResource, IResourceWithCustomWithReference<TSelf>
{
Expand Down
3 changes: 0 additions & 3 deletions src/Aspire.Hosting/Ats/AspireDtoAttribute.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

namespace Aspire.Hosting;

/// <summary>
Expand All @@ -27,7 +25,6 @@ namespace Aspire.Hosting;
/// </para>
/// </remarks>
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct, Inherited = false, AllowMultiple = false)]
[Experimental("ASPIREATS001")]
public sealed class AspireDtoAttribute : Attribute
{
/// <summary>
Expand Down
3 changes: 0 additions & 3 deletions src/Aspire.Hosting/Ats/AspireExportAttribute.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

namespace Aspire.Hosting;

/// <summary>
Expand Down Expand Up @@ -86,7 +84,6 @@ namespace Aspire.Hosting;
AttributeTargets.Method | AttributeTargets.Class | AttributeTargets.Interface | AttributeTargets.Assembly | AttributeTargets.Property,
Inherited = false,
AllowMultiple = true)]
[Experimental("ASPIREATS001")]
public sealed class AspireExportAttribute : Attribute
{
/// <summary>
Expand Down
3 changes: 0 additions & 3 deletions src/Aspire.Hosting/Ats/AspireExportIgnoreAttribute.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

namespace Aspire.Hosting;

/// <summary>
Expand Down Expand Up @@ -40,7 +38,6 @@ namespace Aspire.Hosting;
AttributeTargets.Class | AttributeTargets.Property | AttributeTargets.Method,
Inherited = false,
AllowMultiple = false)]
[Experimental("ASPIREATS001")]
public sealed class AspireExportIgnoreAttribute : Attribute
{
/// <summary>
Expand Down
3 changes: 0 additions & 3 deletions src/Aspire.Hosting/Ats/AspireUnionAttribute.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

namespace Aspire.Hosting;

/// <summary>
Expand Down Expand Up @@ -36,7 +34,6 @@ namespace Aspire.Hosting;
/// </para>
/// </remarks>
[AttributeUsage(AttributeTargets.Parameter | AttributeTargets.Property, AllowMultiple = false)]
[Experimental("ASPIREATS001")]
public sealed class AspireUnionAttribute : Attribute
{
/// <summary>
Expand Down
3 changes: 0 additions & 3 deletions src/Aspire.Hosting/Ats/AspireValueAttribute.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

namespace Aspire.Hosting;

/// <summary>
Expand All @@ -25,7 +23,6 @@ namespace Aspire.Hosting;
/// </remarks>
/// <param name="catalogName">The root name of the generated value catalog.</param>
[AttributeUsage(AttributeTargets.Field | AttributeTargets.Property, Inherited = false, AllowMultiple = false)]
[Experimental("ASPIREATS001")]
public sealed class AspireValueAttribute(string catalogName) : Attribute
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/Ats/ThirdPartyAtsAttributes.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ The ATS capability scanner discovers attributes by their **full type name**, not

## Use the official analyzer package

If your integration project already references `Aspire.Hosting`, you can add the experimental `Aspire.Hosting.Integration.Analyzers` package to get the same authoring diagnostics used by in-repo Aspire integrations:
If your integration project already references `Aspire.Hosting`, you can add the `Aspire.Hosting.Integration.Analyzers` package to get the same authoring diagnostics used by in-repo Aspire integrations:

```xml
<ItemGroup>
Expand Down
6 changes: 0 additions & 6 deletions src/Aspire.TypeSystem/AssemblyInfo.cs

This file was deleted.

1 change: 0 additions & 1 deletion tests/Aspire.Cli.EndToEnd.Tests/ProjectReferenceTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public async Task TypeScriptAppHostWithProjectReferenceIntegration()
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<NoWarn>$(NoWarn);ASPIREATS001</NoWarn>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Aspire.Hosting" Version="{{sdkVersion}}" />
Expand Down
16 changes: 1 addition & 15 deletions tests/Aspire.Hosting.Analyzers.Tests/AnalyzerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

using System.Reflection;
using System.Runtime.Versioning;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp.Testing;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Testing;
Expand All @@ -27,20 +26,7 @@ public static CSharpAnalyzerTest<TAnalyzer, DefaultVerifier> Create<TAnalyzer>(s
// This is required to allow the use of top-level statements in the test source.
OutputKind = Microsoft.CodeAnalysis.OutputKind.ConsoleApplication
},
ReferenceAssemblies = GetReferenceAssemblies(includeAspireHostingReference),
// Suppress ASPIREATS001 (experimental API) warnings in test code
SolutionTransforms =
{
(solution, projectId) =>
{
var project = solution.GetProject(projectId)!;
var compilationOptions = project.CompilationOptions!;
var specificDiagnosticOptions = compilationOptions.SpecificDiagnosticOptions
.Add("ASPIREATS001", ReportDiagnostic.Suppress);
compilationOptions = compilationOptions.WithSpecificDiagnosticOptions(specificDiagnosticOptions);
return solution.WithProjectCompilationOptions(projectId, compilationOptions);
}
}
ReferenceAssemblies = GetReferenceAssemblies(includeAspireHostingReference)
};
test.ExpectedDiagnostics.AddRange(expectedDiagnostics);
return test;
Expand Down
Loading