Skip to content

[release/13.0] Remove .py and .js files from being signed (#13005) #13032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 2 commits into from
Nov 21, 2025
Merged

[release/13.0] Remove .py and .js files from being signed (#13005) #13032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a73fc8
Remove .py files from being signed (#13005)
eerhardt Nov 18, 2025
4f5777e
Don't sign JS files
eerhardt Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
<ItemGroup>
<FileExtensionSignInfo Update=".nupkg" CertificateName="NuGet" />
<FileExtensionSignInfo Update=".zip" CertificateName="None" />
<FileExtensionSignInfo Update=".js" CertificateName="MicrosoftDotNet500" />
<FileExtensionSignInfo Update=".vsix" CertificateName="VsixSHA2" />

<!-- add missing entry for .msi, this can be removed once aspire uses arcade 10.0 -->
<FileExtensionSignInfo Include=".msi" CertificateName="MicrosoftDotNet500" Condition="!@(FileExtensionSignInfo->AnyHaveMetadataValue('Identity', '.msi'))" />

<!-- We don't need to code sign .js files because they are not used in Windows Script Host. -->
<FileExtensionSignInfo Update=".js" CertificateName="None" />
<!-- Remove .py files from being signed. See https://github.com/dotnet/aspire/issues/13004 -->
<FileExtensionSignInfo Update=".py" CertificateName="None" />
</ItemGroup>

<ItemGroup>
Expand Down Expand Up @@ -48,10 +52,6 @@
<FileSignInfo Condition="$([System.OperatingSystem]::IsWindows())" Include="manifest.cat" CertificateName="MicrosoftDotNet500" />
</ItemGroup>

<PropertyGroup>
<NoSignJS>true</NoSignJS>
</PropertyGroup>

<ItemGroup>
<ItemsToSign Include="$(VisualStudioSetupInsertionPath)\**\*.msi" Condition="'$(PostBuildSign)' != 'true'" />
<ItemsToSign Include="$(ArtifactsPackagesDir)**\*.wixpack.zip" Condition="'$(PostBuildSign)' != 'true'" />
Expand Down