Repository navigation
[release/9.4] Made changes to how parameter.Value works - #10357
Merged
Dan Moseley (danmoseley) merged 3 commits intoJul 12, 2025
Merged
Conversation
…er async) waiting for value resolution if WaitForValueTcs is set. - Made GetValueAsync on ParameterResource public. - Changed most code outside of tests to use GetValueAsync instead of Value
github-actions
Bot
requested a review
from Mitch Denny (mitchdenny)
as a code owner
July 12, 2025 17:34
David Fowler (davidfowl)
approved these changes
Jul 12, 2025
Dan Moseley (danmoseley)
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10354 to release/9.4
/cc David Fowler (@davidfowl)
Description
This change was motivated by issues found while testing async parameter resolution. Previously,
ParameterResource.Valuewas used in many places without properly waiting for values to resolve, causing failures. Now,ParameterResource.ValuecallsParameterResource.GetValueAsync(...).GetAwaiter().GetResult(), which—while not ideal—ensures that both sync and async access behave consistently and avoid inconsistent state.There is some risk of introducing deadlocks for consumers that previously used
.Value, but if.Valueis accessed before the TCS is set, it will throw as before.Valuenow blocks (sync over async) waiting for value resolution ifWaitForValueTcsis set.GetValueAsynconParameterResourcepublic.GetValueAsyncinstead ofValue.Fixes #10352
Customer Impact
Testing
Risk
.Valuein a deadlock-prone context; mitigated by existing exception handling.Regression?