Updated DesignTools project's output path#131
Merged
brianlagunas merged 2 commits intomasterfrom Apr 12, 2023
Merged
Conversation
mgoertz-msft
approved these changes
Apr 12, 2023
Collaborator
Author
|
I have an overall concern about the current approach for building the design projects. @mgoertz-msft can you confirm this is the correct way to output these design assemblies? Do we do something in Azure DevOps to correctly package the design assemblies for each TFM? |
Member
|
I guess the validation error may have the answer... |
Member
|
@brianlagunas Found it: Perhaps we need to put the TFMs we are targeting in a .props file so we don't have to change them in multiple different places |
Collaborator
Author
|
Yeah, I think this is an area that needs improvement. I'll get this fixed so that what we have builds, then look to improve this process in the future. |
mgoertz-msft
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Modified the build output path of the DesignTools projects from the old
net45tonet462due to the recent framework upgrades.Bugs Fixed
PR Checklist