Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

chore: update & document release process - #964

Merged
My (mydiemho) merged 3 commits into
masterfrom
myho/updateReleasePipeline
Jun 1, 2020
Merged

chore: update & document release process#964
My (mydiemho) merged 3 commits into
masterfrom
myho/updateReleasePipeline

Conversation

@mydiemho

@mydiemho My (mydiemho) commented May 18, 2020

Copy link
Copy Markdown
Contributor

swimlanes-9edfa565b100bdc65903c210b69a2eaa

GitHubRelease

@mydiemho
My (mydiemho) force-pushed the myho/updateReleasePipeline branch 2 times, most recently from 4958d39 to f007c86 Compare May 19, 2020 02:42

@wbreza Wallace Breza (wbreza) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - Let me know if you need help testing before we pull the trigger on official release.

@@ -0,0 +1,33 @@
name: "GitHub & Web Release [$(SourceBranchName)] - $(Date:yyyyMMdd)$(Rev:.r)"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the old process not working? Looks like a full rewrite on the pipelines?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of the old process was manual. A few of AzDO task has been updated to support the functionality we need so I removed the manual pieces.

destination: azureBlob
storage: $(DEV_STORAGE_ACCOUNT)
containerName: '$web'
# condition: eq(variables['Build.SourceBranch'], 'refs/heads/develop')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be commented out?

@mydiemho My (mydiemho) Jun 1, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, need to remove. thought process is that preview would only go to Dev, but release from both master would update both Dev & Prod web instance

@mydiemho
My (mydiemho) force-pushed the myho/updateReleasePipeline branch from aba8432 to dba6dfe Compare June 1, 2020 18:02
@sonarqubecloud

sonarqubecloud Bot commented Jun 1, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mydiemho
My (mydiemho) merged commit 80add1a into master Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants