This repository was archived by the owner on Dec 7, 2021. It is now read-only.
fix: Resolve UnhandledPromiseRejection in test - #859
Merged
Conversation
Tanner Barlow (tbarlow12)
force-pushed
the
tabarlow/unit-test-fix
branch
from
August 20, 2019 20:28
ca84186 to
f50f3a2
Compare
Elizabeth Halper (elizabethhalper)
approved these changes
Aug 20, 2019
Elizabeth Halper (elizabethhalper)
left a comment
Elizabeth Halper (elizabethhalper)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM :)
Wallace Breza (wbreza)
approved these changes
Aug 22, 2019
Wallace Breza (wbreza)
left a comment
Wallace Breza (wbreza)
left a comment
Contributor
There was a problem hiding this comment.
Nice fix! I remember seeing many of those warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create
window.requirefunction in tests that returns an electron objectResolves #849