fix58438: do not delete comments/code following unterminated string completion

[iisaduan]

fixes #58438

The above issue is a regression bug that happened because of #57839, which was included with 5.5 beta. This PR updates the replacementRange to be more inline with 5.4 behavior, namely completions on unterminated strings will not remove anything to the right of the cursor. Closed strings will replace everything within the quotes.

Examples:

type Test = `abcde';
const test: Test = 'a|; //comment
const test2: Test = 'a|bc // comment
const test3: Test = 'a|bc' //comment

becomes

type Test = `abcde';
const test: Test = 'abcde; //comment
const test2: Test = 'abcdebc // comment
const test:3 Test = 'abcde'; //comment

after completions are triggered at all three locations.

[DanielRosenwasser]

There are only two callers of createTextSpanFromStringLiteralLikeContent, and neither of them omit the position argument, so just make it required (and document what position is supposed to mean)

[DanielRosenwasser]

Also, do you have any tests for when position is strictly greater than the end of the node? I don't think I'm seeing any.

[iisaduan]

Ah, that was old code, thanks for catching it! (I tried to make position optional, but it ended up being needed in more places)

[iisaduan]

It shouldn't be possible in a completion for position > node end but I will add that check incase createTextSpanFromStringLiteralLikeContent will be used in a non-completion context in the future.

[DanielRosenwasser]

The only thing I can think of is possibly an unterminated string literal on the previous line

let s: "string" = "s
/*$*/

[iisaduan]

Completions won't be triggered on new lines -- so

type LongString = `asdf
string
line`

let s: LongString = `asdf
/**/
  ^ no suggestions

let r: LongString = `asdf/**/
                          ^ completes to `asdf\nstring\nline`

[DanielRosenwasser]

@typescript-bot cherry-pick to release-5.5

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
cherry-pick to release-5.5	✅ Started	✅ Results

[typescript-bot]

Hey, @DanielRosenwasser! I've created #58762 for you.