Fixing a case when text is pasted into a blank file #58595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
src/server/project.ts
Outdated
Comment on lines
2241
to
2244
| const originalText = Debug.checkDefined(this.program?.getSourceFile(rootFile)?.getText()); | ||
| Debug.assert(this.program && this.program.getSourceFile(rootFile)); | ||
|
|
||
| this.getScriptInfo(rootFile)?.editContent(0, this.program.getSourceFile(rootFile)!.getText().length, updatedText); |
Member
There was a problem hiding this comment.
Suggested change
| const originalText = Debug.checkDefined(this.program?.getSourceFile(rootFile)?.getText()); | |
| Debug.assert(this.program && this.program.getSourceFile(rootFile)); | |
| this.getScriptInfo(rootFile)?.editContent(0, this.program.getSourceFile(rootFile)!.getText().length, updatedText); | |
| const originalText = Debug.checkDefined(Debug.checkDefined(this.program?.getSourceFile(rootFile), "Expected file to be part of program").getText(), "Expected some text in the file"); | |
| this.getScriptInfo(rootFile)?.editContent(0, originalText.length, updatedText) | |
sheetalkamat
approved these changes
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy/paste api was tested on the vscode side and a bug was found when pasting to a blank text file. It was caused by checking
Debug.assert()on a blank text file. This is fixed by addingDebug.checkDefined()instead.